From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Nicholas Mosier <nmosier@stanford.edu>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
qemu-trivial@nongnu.org
Subject: Re: [PATCH] i386/tcg/svm: fix comma operator typo
Date: Wed, 12 Nov 2025 08:14:52 +0100 [thread overview]
Message-ID: <11781df4-ef38-4ba4-811e-8da50aa586a9@linaro.org> (raw)
In-Reply-To: <20251111-i386-svm-vmexit-typo-fix-v1-1-49f0414472cd@stanford.edu>
On 11/11/25 22:57, Nicholas Mosier wrote:
> A comma operator inappropriately terminates an expression
> in svm_helper.c. Replace it with a semicolon.
>
> Signed-off-by: Nicholas Mosier <nmosier@stanford.edu>
> ---
> As an apparent typo, line 742 in target/i386/tcg/system/svm_helper.c
> ends with a comma operator, rather than a statement-ending semicolon.
> This doesn't introduce any functionality bugs as the code is currently
> written, but could easily introduce bugs in the future if a new line
> of code is added following the comma operator.
>
> This patch replaces the comma with a semicolon, as the original author
> probably intended.
> ---
> target/i386/tcg/system/svm_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-11-12 7:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 21:57 [PATCH] i386/tcg/svm: fix comma operator typo Nicholas Mosier
2025-11-12 7:14 ` Philippe Mathieu-Daudé [this message]
2025-11-12 8:30 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11781df4-ef38-4ba4-811e-8da50aa586a9@linaro.org \
--to=philmd@linaro.org \
--cc=eduardo@habkost.net \
--cc=nmosier@stanford.edu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).