* [PATCH] i386/tcg/svm: fix comma operator typo
@ 2025-11-11 21:57 Nicholas Mosier
2025-11-12 7:14 ` Philippe Mathieu-Daudé
2025-11-12 8:30 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Nicholas Mosier @ 2025-11-11 21:57 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Richard Henderson, Eduardo Habkost, qemu-trivial,
Nicholas Mosier
A comma operator inappropriately terminates an expression
in svm_helper.c. Replace it with a semicolon.
Signed-off-by: Nicholas Mosier <nmosier@stanford.edu>
---
As an apparent typo, line 742 in target/i386/tcg/system/svm_helper.c
ends with a comma operator, rather than a statement-ending semicolon.
This doesn't introduce any functionality bugs as the code is currently
written, but could easily introduce bugs in the future if a new line
of code is added following the comma operator.
This patch replaces the comma with a semicolon, as the original author
probably intended.
---
target/i386/tcg/system/svm_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/tcg/system/svm_helper.c b/target/i386/tcg/system/svm_helper.c
index 505788b0e2..c32cc7ac30 100644
--- a/target/i386/tcg/system/svm_helper.c
+++ b/target/i386/tcg/system/svm_helper.c
@@ -742,7 +742,7 @@ void cpu_vmexit(CPUX86State *env, uint32_t exit_code, uint64_t exit_info_1,
exit_code);
x86_stq_phys(cs, env->vm_vmcb + offsetof(struct vmcb,
- control.exit_info_1), exit_info_1),
+ control.exit_info_1), exit_info_1);
/* remove any pending exception */
env->old_exception = -1;
---
base-commit: 593aee5df98b4a862ff8841a57ea3dbf22131a5f
change-id: 20251111-i386-svm-vmexit-typo-fix-b5ce1954d254
Best regards,
--
Nicholas Mosier <nmosier@stanford.edu>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i386/tcg/svm: fix comma operator typo
2025-11-11 21:57 [PATCH] i386/tcg/svm: fix comma operator typo Nicholas Mosier
@ 2025-11-12 7:14 ` Philippe Mathieu-Daudé
2025-11-12 8:30 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-11-12 7:14 UTC (permalink / raw)
To: Nicholas Mosier, qemu-devel
Cc: Paolo Bonzini, Richard Henderson, Eduardo Habkost, qemu-trivial
On 11/11/25 22:57, Nicholas Mosier wrote:
> A comma operator inappropriately terminates an expression
> in svm_helper.c. Replace it with a semicolon.
>
> Signed-off-by: Nicholas Mosier <nmosier@stanford.edu>
> ---
> As an apparent typo, line 742 in target/i386/tcg/system/svm_helper.c
> ends with a comma operator, rather than a statement-ending semicolon.
> This doesn't introduce any functionality bugs as the code is currently
> written, but could easily introduce bugs in the future if a new line
> of code is added following the comma operator.
>
> This patch replaces the comma with a semicolon, as the original author
> probably intended.
> ---
> target/i386/tcg/system/svm_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i386/tcg/svm: fix comma operator typo
2025-11-11 21:57 [PATCH] i386/tcg/svm: fix comma operator typo Nicholas Mosier
2025-11-12 7:14 ` Philippe Mathieu-Daudé
@ 2025-11-12 8:30 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2025-11-12 8:30 UTC (permalink / raw)
To: Nicholas Mosier
Cc: qemu-devel, Richard Henderson, Eduardo Habkost, qemu-trivial
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-12 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-11 21:57 [PATCH] i386/tcg/svm: fix comma operator typo Nicholas Mosier
2025-11-12 7:14 ` Philippe Mathieu-Daudé
2025-11-12 8:30 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).