Re: [Qemu-devel] [PATCH 2/3] audio: paaudio: fix client name

[Maxim Levitsky <mlevitsk@redhat.com>]

On Mon, 2019-08-26 at 02:29 +0200, Kővágó, Zoltán wrote:
> pa_context_new expects a client name, not a server socket path.
> 
> Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
> ---
>  audio/paaudio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/audio/paaudio.c b/audio/paaudio.c
> index bfef9acaad..777b8e4718 100644
> --- a/audio/paaudio.c
> +++ b/audio/paaudio.c
> @@ -866,7 +866,7 @@ static void *qpa_conn_init(const char *server)
>      }
>  
>      c->context = pa_context_new(pa_threaded_mainloop_get_api(c->mainloop),
> -                                server);
> +                                "qemu");
>      if (!c->context) {
>          goto fail;
>      }

Also tested, and this works.

May I suggest though to make this configurable as well, for the sake of
usability since gnome sound settings show only the client name, and it
is per each sound card.
Although on the other thing the client name is qemu.

Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>

Best regards,
	Maxim Levitsky