From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IMQ3b-0006vZ-30
	for qemu-devel@nongnu.org; Sat, 18 Aug 2007 11:17:43 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IMQ3Z-0006uu-CL
	for qemu-devel@nongnu.org; Sat, 18 Aug 2007 11:17:42 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IMQ3Z-0006ud-5v
	for qemu-devel@nongnu.org; Sat, 18 Aug 2007 11:17:41 -0400
Received: from wa-out-1112.google.com ([209.85.146.177])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1IMQ3W-0004YV-DH
	for qemu-devel@nongnu.org; Sat, 18 Aug 2007 11:17:38 -0400
Received: by wa-out-1112.google.com with SMTP id k22so256144waf
	for <qemu-devel@nongnu.org>; Sat, 18 Aug 2007 08:17:35 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <20070817231149.544849769@gmail.com>
References: <20070817231149.544849769@gmail.com>
Content-Type: text/plain
Date: Sat, 18 Aug 2007 10:17:36 -0500
Message-Id: <1187450256.13580.1.camel@squirrel>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [kvm-devel] [PATCH 0/4] Rework alarm timer
	infrastrucure - take 2
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: kvm-devel@lists.sf.net, qemu-devel@nongnu.org


On Sat, 2007-08-18 at 01:11 +0200, Luca Tettamanti wrote:
> Hello,
> in reply to this mail I will send a serie of 4 patches that cleans up and
> expands the alarm timer handling in QEMU. Patches have been rebased on QEMU
> CVS.
> 
> Patch 1 is mostly a cleanup of the existing code; instead of having multiple
> #ifdefs to handle different timers scattered all over the code I've created a
> modular infrastructure where each timer type is self-contained and generic code
> is more readable. The resulting code is functionally equivalent to the old one.
> 
> Patch 2 implements the "-clock" command line option proposed by Daniel Berrange
> and Avi Kivity. By default QEMU tries RTC and then falls back to unix timer;
> user can override the order of the timer through this options. Syntax is pretty
> simple: -clock timer1,timer2,etc. (QEMU will pick the first one that works).
> 
> Patch 3 adds support for HPET under Linux (which is basically my old patch). As
> suggested HPET takes precedence over other timers, but of course this can be
> overridden.
> 
> Patch 4 introduces "dynticks" timer source; patch is mostly based on the work
> Dan Kenigsberg. dynticks is now the default alarm timer.

Why do you guard dynticks with #ifdef?  Is there any reason why you
wouldn't want to use dynticks?

Regards,

Anthony Liguori

> Luca