From: Eric Blake <eblake@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Laurent Vivier" <lvivier@redhat.com>,
"Riku Voipio" <riku.voipio@iki.fi>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] syscall: fix compiler warnings (clang 5)
Date: Wed, 10 May 2017 14:41:23 -0500 [thread overview]
Message-ID: <118e342f-4c48-5652-10e6-1d15e6a5537d@redhat.com> (raw)
In-Reply-To: <f7193a8d-0086-d61c-b214-76c7f204d062@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
>>
>> The "for" loop scans the structure to find the rt_dev field, and we
>> should always enter in the first "if", so "host_rt_dev_ptr" is always
>> set.
>
> It's better indeed, I'll use g_assert_nonnull() and resend.
Careful - we haven't yet resolved whether g_assert_nonnull() is safe to use.
https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg05499.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2017-05-10 19:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 0:41 [Qemu-devel] [PATCH] syscall: fix compiler warnings (clang 5) Philippe Mathieu-Daudé
2017-05-10 12:32 ` Laurent Vivier
2017-05-10 14:38 ` Philippe Mathieu-Daudé
2017-05-10 19:41 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=118e342f-4c48-5652-10e6-1d15e6a5537d@redhat.com \
--to=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).