From: Jocelyn Mayer <l_indien@magic.fr>
To: Thiemo Seufer <ths@networkno.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Updated RFC: linux user problems]]
Date: Mon, 24 Sep 2007 20:27:54 +0200 [thread overview]
Message-ID: <1190658474.28991.35.camel@jma4.dev.netgem.com> (raw)
In-Reply-To: <20070924121929.GA27468@networkno.de>
On Mon, 2007-09-24 at 13:19 +0100, Thiemo Seufer wrote:
> J. Mayer wrote:
> [snip]
> > > > > May someone take a look at my patch and say if it seems reasonable to
> > > > > include this in the repository ?
> > > >
> > > > Looks reasonable, but introduces new compiler warnings
> > > > (on a ppc32/Linux host):
> >
> > The reported warnings have been fixed.
> > There are still a lot of warnings related to 32/64 bits invalid casts on
> > 64 bits hosts (see above) which will need to be fixed once.
> >
> > I also changed some parameters of do_ipc from long to int (instead of
> > target_long), following the do_ipc man page specification, and reported
> > this change in child functions. There may be more to do...
> >
> > Please comment...
>
> Fine with me, FWIW.
Great. I may do another pass, to check all helpers against long/int
confusion to avoid using target_ulong when not necessary.
I would appreciate anyone who would test the patch on other platforms
than x86 / PowerPC, as I would like not to break everything...
next prev parent reply other threads:[~2007-09-24 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 6:39 [Qemu-devel] Updated RFC: linux user problems]] J. Mayer
2007-09-24 12:19 ` Thiemo Seufer
2007-09-24 18:27 ` Jocelyn Mayer [this message]
2007-09-25 4:39 ` Thayne Harbaugh
2007-09-25 8:08 ` J. Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190658474.28991.35.camel@jma4.dev.netgem.com \
--to=l_indien@magic.fr \
--cc=qemu-devel@nongnu.org \
--cc=ths@networkno.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).