From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IZsfK-0008H6-8Z for qemu-devel@nongnu.org; Mon, 24 Sep 2007 14:28:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IZsfI-0008FF-DJ for qemu-devel@nongnu.org; Mon, 24 Sep 2007 14:28:17 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IZsfI-0008F8-5M for qemu-devel@nongnu.org; Mon, 24 Sep 2007 14:28:16 -0400 Received: from bangui.magic.fr ([195.154.194.245]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IZsfG-0005ev-Fu for qemu-devel@nongnu.org; Mon, 24 Sep 2007 14:28:15 -0400 Subject: Re: [Qemu-devel] Updated RFC: linux user problems]] From: Jocelyn Mayer In-Reply-To: <20070924121929.GA27468@networkno.de> References: <1190356760.14938.409.camel@rapid> <20070924121929.GA27468@networkno.de> Content-Type: text/plain Date: Mon, 24 Sep 2007 20:27:54 +0200 Message-Id: <1190658474.28991.35.camel@jma4.dev.netgem.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: l_indien@magic.fr, qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thiemo Seufer Cc: qemu-devel@nongnu.org On Mon, 2007-09-24 at 13:19 +0100, Thiemo Seufer wrote: > J. Mayer wrote: > [snip] > > > > > May someone take a look at my patch and say if it seems reasonable to > > > > > include this in the repository ? > > > > > > > > Looks reasonable, but introduces new compiler warnings > > > > (on a ppc32/Linux host): > > > > The reported warnings have been fixed. > > There are still a lot of warnings related to 32/64 bits invalid casts on > > 64 bits hosts (see above) which will need to be fixed once. > > > > I also changed some parameters of do_ipc from long to int (instead of > > target_long), following the do_ipc man page specification, and reported > > this change in child functions. There may be more to do... > > > > Please comment... > > Fine with me, FWIW. Great. I may do another pass, to check all helpers against long/int confusion to avoid using target_ulong when not necessary. I would appreciate anyone who would test the patch on other platforms than x86 / PowerPC, as I would like not to break everything...