From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IbxjS-000089-K1 for qemu-devel@nongnu.org; Sun, 30 Sep 2007 08:17:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IbxjQ-0008WQ-Hw for qemu-devel@nongnu.org; Sun, 30 Sep 2007 08:17:09 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IbxjQ-0008WE-1r for qemu-devel@nongnu.org; Sun, 30 Sep 2007 08:17:08 -0400 Received: from bangui.magic.fr ([195.154.194.245]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IbxjO-0000Ww-D8 for qemu-devel@nongnu.org; Sun, 30 Sep 2007 08:17:07 -0400 Received: from [192.168.0.2] (ppp-36.net-123.static.magiconline.fr [80.118.184.36]) by bangui.magic.fr (8.13.1/8.13.1) with ESMTP id l8UCH1Mc012973 for ; Sun, 30 Sep 2007 14:17:01 +0200 Subject: Re: [Qemu-devel] Build failure on OS X From: "J. Mayer" In-Reply-To: <494D52E6-D90D-4426-A866-8D413F9333B6@web.de> References: <9DF95EE0-A0EB-443E-850F-881F2A7B3318@web.de> <1191152728.29900.102.camel@rapid> <494D52E6-D90D-4426-A866-8D413F9333B6@web.de> Content-Type: text/plain; charset=ISO-8859-15 Date: Sun, 30 Sep 2007 14:17:02 +0200 Message-Id: <1191154622.29900.118.camel@rapid> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sun, 2007-09-30 at 14:05 +0200, Andreas F=E4rber wrote: > Hi, >=20 > Am 30.09.2007 um 13:45 schrieb J. Mayer: >=20 > >> Anyone any idea what might've caused this build failure? I'm fairly > >> certain I haven't messed with or updated the system headers. > > > > have you just updated your CVS co ? >=20 > Yes. >=20 > > Please try to comment the "always_inline" definition in vl.h / > > exec-all.h. > > If this is what's breaking your build, I'll revert this definition. >=20 > It is, thanks for the pointer! (The source file itself didn't appear =20 > to have been updated.) >=20 > >> With line 284 of math.h reading: > >> static __inline__ int __inline_isfinitef (float ) > >> __MATH_H_ALWAYS_INLINE__; > > > > The fact the error mentions "__attribute__" and ALWAYS_INLINE make me > > think the always_inline defintion is the suspect here.... >=20 > I believe Apple's GCC in general has a problem with the __attribute__ =20 > notation. The ppc*-softmmu fail to build for some time due to its use =20 > for aliasing in hw/ppc.c. Maybe we could add a configure check for =20 > this feature to have a conditional define? That would allow a more =20 > elegant fix than the one I use locally and had previously suggested. Sorry for introducing this problem... Would this new definition solve the compilation failure ? #ifndef always_inline #if (__GNUC__ < 3) || defined(__APPLE__) #define always_inline inline #else #define always_inline __attribute__ (( always_inline )) inline #endif #endif Regards. --=20 J. Mayer Never organized