From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IbzvJ-000698-1X for qemu-devel@nongnu.org; Sun, 30 Sep 2007 10:37:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IbzvH-000684-DF for qemu-devel@nongnu.org; Sun, 30 Sep 2007 10:37:32 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IbzvH-000681-5y for qemu-devel@nongnu.org; Sun, 30 Sep 2007 10:37:31 -0400 Received: from bangui.magic.fr ([195.154.194.245]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IbzvG-0007Xp-VX for qemu-devel@nongnu.org; Sun, 30 Sep 2007 10:37:31 -0400 Received: from [192.168.0.2] (ppp-36.net-123.static.magiconline.fr [80.118.184.36]) by bangui.magic.fr (8.13.1/8.13.1) with ESMTP id l8UEbPNp020627 for ; Sun, 30 Sep 2007 16:37:25 +0200 Subject: Re: [Qemu-devel] Build failure on OS X From: "J. Mayer" In-Reply-To: References: <9DF95EE0-A0EB-443E-850F-881F2A7B3318@web.de> <1191152728.29900.102.camel@rapid> <494D52E6-D90D-4426-A866-8D413F9333B6@web.de> <1191154622.29900.118.camel@rapid> <5CD94FD2-E210-4C08-8CBA-11B0EFDC0AA4@web.de> <1191158854.29900.131.camel@rapid> Content-Type: text/plain; charset=ISO-8859-15 Date: Sun, 30 Sep 2007 16:37:28 +0200 Message-Id: <1191163048.29900.138.camel@rapid> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sun, 2007-09-30 at 16:28 +0200, Andreas F=E4rber wrote: > Am 30.09.2007 um 15:27 schrieb J. Mayer: >=20 > > On Sun, 2007-09-30 at 15:08 +0200, Andreas F=E4rber wrote: > >> Am 30.09.2007 um 14:17 schrieb J. Mayer: > >>> Would this new definition solve the compilation failure ? > >>> > >>> #ifndef always_inline > >>> #if (__GNUC__ < 3) || defined(__APPLE__) > >>> #define always_inline inline > >>> #else > >>> #define always_inline __attribute__ (( always_inline )) inline > >>> #endif > >>> #endif > >> > >> It does. > > > > OK, then I will commit this fixup, even if it may generate slower cod= e > > for interrupt processing (which is already something slow...). >=20 > Well, slower compared to Linux certainly, but there's no fancy =20 > acceleration anyway. I consider working+slow better than not working =20 > at all. I fully agree... > If someone has a speedup idea for the __APPLE__ case, that could =20 > still be applied separately. I guess there are some already defined macros in the Apple build environmnet that should be used instead. But I don't know too much about this environment... The slowdown is really not an issue in that particular case. > > the alias attribute is used to define a new function name that =20 > > actually > > refer to another existant function, this to avoid code duplication. W= e > > can easily avoid using it using an inline function for the actual > > implementation and calling it from different places. Please take a =20 > > look > > at this patch. >=20 > Patch looks okay to me and compiles. Again, I have no idea about the =20 > implications and any performance impact. It has no performance impact, it just duplicates one (small) function in the generated object, which will not have any impact. > Either way, if I run "qemu-system-ppc -boot d -cdrom debian-40r0-=20 > powerpc-DVD-1.iso" this is what I get: >=20 > starting qemu... > qemu: fatal: Unable to find PowerPC CPU definition >=20 > NIP fffffffc LR 00000000 CTR 00000000 > Bus error > I haven't used it in a while; as reported earlier, it didn't really =20 > work back then either, but it worked "more", i.e. started to boot. =20 > But this is with or without the patch, so unrelated - just saying I =20 > can't confirm that this patch works 100%. OK, just checked and I have this problem too. Will fix it as soon as I can. In between, you can just try to force the CPU, adding '-cpu 750' or '-cpu 604' to your command line. Thanks for this report ! Regards. --=20 J. Mayer Never organized