From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Iea4k-0003jA-LG
	for qemu-devel@nongnu.org; Sun, 07 Oct 2007 13:37:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Iea4i-0003eC-Jn
	for qemu-devel@nongnu.org; Sun, 07 Oct 2007 13:37:58 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Iea4i-0003dq-FX
	for qemu-devel@nongnu.org; Sun, 07 Oct 2007 13:37:56 -0400
Received: from bangui.magic.fr ([195.154.194.245])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <l_indien@magic.fr>) id 1Iea4h-0004Ck-PG
	for qemu-devel@nongnu.org; Sun, 07 Oct 2007 13:37:56 -0400
Subject: Re: [Qemu-devel] [RFC, PATCH] Support for loading 32 bit ELF files
	for 64 bit linux-user
From: "J. Mayer" <l_indien@magic.fr>
In-Reply-To: <f43fc5580710071007s494b3c21ua51a23278925dbbe@mail.gmail.com>
References: <f43fc5580710070545x7f065e3ayef303218b3997b33@mail.gmail.com>
	<20071007162147.GB13192@networkno.de>
	<f43fc5580710071007s494b3c21ua51a23278925dbbe@mail.gmail.com>
Content-Type: text/plain
Date: Sun, 07 Oct 2007 19:35:52 +0200
Message-Id: <1191778553.9976.32.camel@rapid>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Sun, 2007-10-07 at 20:07 +0300, Blue Swirl wrote:
> On 10/7/07, Thiemo Seufer <ths@networkno.de> wrote:
> > Blue Swirl wrote:
> > [snip]
> > > Index: qemu/linux-user/qemu.h
> > > ===================================================================
> > > --- qemu.orig/linux-user/qemu.h       2007-10-07 10:50:05.000000000 +0000
> > > +++ qemu/linux-user/qemu.h    2007-10-07 10:51:09.000000000 +0000
> > > @@ -33,6 +33,7 @@
> > >          target_ulong    data_offset;
> > >          char            **host_argv;
> > >       int             personality;
> > > +        int             is_64bits;
> > >  };
> >
> > I think the 64bit-ness should be part of the personality. In the end,
> > we need a notion of the ABI in use, not just a specific cpu feature flag.
> 
> Good point. I've updated the patch to use the personality field
> instead, for that I updated the personality stuff.

Well done !
I really like this new version as it is far less intrusive. And I guess
it can quite easily be used by other 64 bits targets.

-- 
J. Mayer <l_indien@magic.fr>
Never organized