From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ifwsc-0004x2-A0 for qemu-devel@nongnu.org; Thu, 11 Oct 2007 08:11:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IfwsW-0004vP-Of for qemu-devel@nongnu.org; Thu, 11 Oct 2007 08:11:06 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IfwsW-0004vL-HJ for qemu-devel@nongnu.org; Thu, 11 Oct 2007 08:11:00 -0400 Received: from honiara.magic.fr ([195.154.193.36]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IfwsV-0005XY-6U for qemu-devel@nongnu.org; Thu, 11 Oct 2007 08:11:00 -0400 Subject: Re: [Qemu-devel] [PATCH] syscall_target_errno.patch From: "J. Mayer" In-Reply-To: <1192073888.8097.14.camel@phantasm.home.enterpriseandprosperity.com> References: <1192073888.8097.14.camel@phantasm.home.enterpriseandprosperity.com> Content-Type: text/plain Date: Thu, 11 Oct 2007 14:10:33 +0200 Message-Id: <1192104633.9976.216.camel@rapid> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: thayne@c2.net, qemu-devel@nongnu.org On Wed, 2007-10-10 at 21:38 -0600, Thayne Harbaugh wrote: > I appreciate the work that Jocelyn did to correct the types used > throughout linux-user/syscall.c. Along those same lines I am working on > several patches to eliminate some incorrect constructs that have crept > into syscall.c - some of which I have ignorantly propagated in previous > patches that I have submitted. > > I have noticed that many functions in syscall.c return a *host* errno > when a *target* errno should be return. At the same time, there are > several places in syscall.c:do_syscall() that immediately return an > errno rather than setting the return value and exiting through the > syscall return value reporting at the end of do_syscall(). > > This patch addresses both of those problems at once rather than touching > the exact same errno return lines twice in do_syscall(). It also > touches a few functions in linux-user/signal.c that are called from > do_syscall(). > > Please send comments - I have several more patches that will build on > this one as well as a few more patches that will fix other incorrect > constructs with target/host address handling. > > Thanks. Hi, there are still a lot of problems hidden in syscalls.c and signal.c, as you noticed. Your patch seems OK to me and adding all those comments is imho really great. My only remark is a cosmetic one: I don't like too much hidding 'goto' in macros... -- J. Mayer Never organized