From: "J. Mayer" <l_indien@magic.fr>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu host-utils.c
Date: Wed, 24 Oct 2007 12:35:36 +0200 [thread overview]
Message-ID: <1193222136.16781.229.camel@rapid> (raw)
In-Reply-To: <471F1C7F.8060003@bellard.org>
On Wed, 2007-10-24 at 12:20 +0200, Fabrice Bellard wrote:
> I strongly suggest to reuse my code which was in target-i386/helper.c
> revision 1.80 which was far easier to validate. Moreover, integer
> divisions from target-i386/helper.c should be put in the same file.
I fully agree with this. I still use the same code in the PowerPC
op_helper.c file because I never conviced myself that the host_utils
version was bug-free. I would likely switch to the common version if I
could be sure it cannot lead to any regression.
> Thiemo Seufer wrote:
> > CVSROOT: /sources/qemu
> > Module name: qemu
> > Changes by: Thiemo Seufer <ths> 07/10/23 23:22:54
> >
> > Modified files:
> > . : host-utils.c
> >
> > Log message:
> > Fix overflow when multiplying two large positive numbers.
> >
> > CVSWeb URLs:
> > http://cvs.savannah.gnu.org/viewcvs/qemu/host-utils.c?cvsroot=qemu&r1=1.1&r2=1.2
> >
> >
> >
> >
>
>
>
--
J. Mayer <l_indien@magic.fr>
Never organized
next prev parent reply other threads:[~2007-10-24 10:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 23:22 [Qemu-devel] qemu host-utils.c Thiemo Seufer
2007-10-24 10:20 ` Fabrice Bellard
2007-10-24 10:35 ` J. Mayer [this message]
2007-10-24 17:37 ` Thiemo Seufer
2007-10-24 18:46 ` Jocelyn Mayer
2007-10-24 19:26 ` Fabrice Bellard
2007-10-24 22:26 ` J. Mayer
2007-10-25 23:00 ` Thiemo Seufer
2007-10-27 6:45 ` Blue Swirl
2007-10-27 11:11 ` Thiemo Seufer
-- strict thread matches above, loose matches on Subject: below --
2007-10-25 23:00 Thiemo Seufer
2007-11-05 13:01 Jocelyn Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193222136.16781.229.camel@rapid \
--to=l_indien@magic.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).