From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IkdaQ-0005lU-0X
	for qemu-devel@nongnu.org; Wed, 24 Oct 2007 06:35:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IkdaP-0005lD-DA
	for qemu-devel@nongnu.org; Wed, 24 Oct 2007 06:35:41 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IkdaP-0005ky-7I
	for qemu-devel@nongnu.org; Wed, 24 Oct 2007 06:35:41 -0400
Received: from honiara.magic.fr ([195.154.193.36])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <l_indien@magic.fr>) id 1IkdaM-0000y9-WE
	for qemu-devel@nongnu.org; Wed, 24 Oct 2007 06:35:40 -0400
Received: from [192.168.0.2] (ppp-36.net-123.static.magiconline.fr
	[80.118.184.36])
	by honiara.magic.fr (8.13.1/8.13.1) with ESMTP id l9OAZY0k016763
	for <qemu-devel@nongnu.org>; Wed, 24 Oct 2007 12:35:34 +0200
Subject: Re: [Qemu-devel] qemu host-utils.c
From: "J. Mayer" <l_indien@magic.fr>
In-Reply-To: <471F1C7F.8060003@bellard.org>
References: <E1IkT5K-0007xn-ES@cvs.savannah.gnu.org>
	<471F1C7F.8060003@bellard.org>
Content-Type: text/plain
Date: Wed, 24 Oct 2007 12:35:36 +0200
Message-Id: <1193222136.16781.229.camel@rapid>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org


On Wed, 2007-10-24 at 12:20 +0200, Fabrice Bellard wrote:
> I strongly suggest to reuse my code which was in target-i386/helper.c 
> revision 1.80 which was far easier to validate. Moreover, integer 
> divisions from target-i386/helper.c should be put in the same file.

I fully agree with this. I still use the same code in the PowerPC
op_helper.c file because I never conviced myself that the host_utils
version was bug-free. I would likely switch to the common version if I
could be sure it cannot lead to any regression.


> Thiemo Seufer wrote:
> > CVSROOT:	/sources/qemu
> > Module name:	qemu
> > Changes by:	Thiemo Seufer <ths>	07/10/23 23:22:54
> > 
> > Modified files:
> > 	.              : host-utils.c 
> > 
> > Log message:
> > 	Fix overflow when multiplying two large positive numbers.
> > 
> > CVSWeb URLs:
> > http://cvs.savannah.gnu.org/viewcvs/qemu/host-utils.c?cvsroot=qemu&r1=1.1&r2=1.2
> > 
> > 
> > 
> > 
> 
> 
> 
-- 
J. Mayer <l_indien@magic.fr>
Never organized