Re: [Qemu-devel] qemu vl.c vl.h hw/an5206.c hw/etraxfs.c hw/inte...

["J. Mayer" <l_indien@magic.fr>]

On Wed, 2007-10-31 at 01:54 +0000, Andrzej Zaborowski wrote:
> CVSROOT:	/sources/qemu
> Module name:	qemu
> Changes by:	Andrzej Zaborowski <balrog>	07/10/31 01:54:05
> 
> Modified files:
> 	.              : vl.c vl.h 
> 	hw             : an5206.c etraxfs.c integratorcp.c mcf5208.c 
> 	                 mips_malta.c mips_mipssim.c mips_pica61.c 
> 	                 mips_r4k.c palm.c pc.c ppc405_boards.c 
> 	                 ppc_chrp.c ppc_oldworld.c ppc_prep.c r2d.c 
> 	                 realview.c shix.c spitz.c sun4m.c sun4u.c 
> 	                 versatilepb.c 
> 
> Log message:
> 	Set boot sequence from command line (Dan Kenigsberg).

There have been remarks about this patch that have not been addressed
(not even answered, in fact).  For example, the MAX_BOOT_DEVICES is set
to 3 when more than 3 boot devices are possible to select (see the
BOOTCHARS definition), which clearly shows the patch is not consistent.
Furthermore, the patch breaks the coding style in some files (at least
the ones I checked), which is weird.
Seems _very_ strange to see it commited, then.

-- 
J. Mayer <l_indien@magic.fr>
Never organized