From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1In3Cd-00071i-Ik
	for qemu-devel@nongnu.org; Tue, 30 Oct 2007 22:21:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1In3Cc-000714-5m
	for qemu-devel@nongnu.org; Tue, 30 Oct 2007 22:21:07 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1In3Cb-00070y-S4
	for qemu-devel@nongnu.org; Tue, 30 Oct 2007 22:21:05 -0400
Received: from bangui.magic.fr ([195.154.194.245])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <l_indien@magic.fr>) id 1In3Cb-0007A8-Dd
	for qemu-devel@nongnu.org; Tue, 30 Oct 2007 22:21:05 -0400
Subject: Re: [Qemu-devel] qemu vl.c vl.h hw/an5206.c hw/etraxfs.c hw/inte...
From: "J. Mayer" <l_indien@magic.fr>
In-Reply-To: <E1In2mT-0000lo-2D@cvs.savannah.gnu.org>
References: <E1In2mT-0000lo-2D@cvs.savannah.gnu.org>
Content-Type: text/plain
Date: Wed, 31 Oct 2007 03:21:00 +0100
Message-Id: <1193797260.16781.380.camel@rapid>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org


On Wed, 2007-10-31 at 01:54 +0000, Andrzej Zaborowski wrote:
> CVSROOT:	/sources/qemu
> Module name:	qemu
> Changes by:	Andrzej Zaborowski <balrog>	07/10/31 01:54:05
> 
> Modified files:
> 	.              : vl.c vl.h 
> 	hw             : an5206.c etraxfs.c integratorcp.c mcf5208.c 
> 	                 mips_malta.c mips_mipssim.c mips_pica61.c 
> 	                 mips_r4k.c palm.c pc.c ppc405_boards.c 
> 	                 ppc_chrp.c ppc_oldworld.c ppc_prep.c r2d.c 
> 	                 realview.c shix.c spitz.c sun4m.c sun4u.c 
> 	                 versatilepb.c 
> 
> Log message:
> 	Set boot sequence from command line (Dan Kenigsberg).

There have been remarks about this patch that have not been addressed
(not even answered, in fact).  For example, the MAX_BOOT_DEVICES is set
to 3 when more than 3 boot devices are possible to select (see the
BOOTCHARS definition), which clearly shows the patch is not consistent.
Furthermore, the patch breaks the coding style in some files (at least
the ones I checked), which is weird.
Seems _very_ strange to see it commited, then.

-- 
J. Mayer <l_indien@magic.fr>
Never organized