[Qemu-devel] Re: [kvm-devel] [PATCH 1/2] KVM userspace: Add PCI device passthrough support

[Hollis Blanchard <hollisb@us.ibm.com>]

I'm sorry these comments aren't substantive, but please watch your
whitespace...

On Wed, 2007-11-07 at 21:45 +0200, Amit Shah wrote:
> diff --git a/qemu/Makefile b/qemu/Makefile
> index 053c88c..3e599f3 100644
> --- a/qemu/Makefile
> +++ b/qemu/Makefile
> @@ -37,7 +37,7 @@ qemu-img$(EXESUF): qemu-img.c cutils.c block.c
> block-raw.c block-cow.c block-qco
>  dyngen$(EXESUF): dyngen.c
>         $(HOST_CC) $(CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -o $@ $^
> 
> -clean:
> +clean: 
>  # avoid old build problems by removing potentially incorrect old
> files
>         rm -f config.mak config.h op-i386.h opc-i386.h gen-op-i386.h
> op-arm.h opc-arm.h gen-op-arm.h
>         rm -f *.o *.a $(TOOLS) dyngen$(EXESUF) TAGS cscope.* *.pod *~
> */*~

Extra space.

> @@ -88,8 +88,8 @@ endif
>  test speed test2: all
>         $(MAKE) -C tests $@
> 
> -TAGS:
> -       etags *.[ch] tests/*.[ch]
> +TAGS: 
> +       etags *.[ch] tests/*.[ch] hw/passthrough/*.[ch]
> 
>  cscope:
>         rm -f ./cscope.*

Another extra space.

> diff --git a/qemu/exec.c b/qemu/exec.c
> index 3e588d5..7a21ca5 100644
> --- a/qemu/exec.c
> +++ b/qemu/exec.c
> @@ -2484,6 +2484,7 @@ int cpu_register_io_memory(int io_index,
>          if (io_mem_nb >= IO_MEM_NB_ENTRIES)
>              return -1;
>          io_index = io_mem_nb++;
> +       fprintf(stderr, "iomem index %d out of %d\n", io_index,
> IO_MEM_NB_ENTRIES);
>      } else {
>          if (io_index >= IO_MEM_NB_ENTRIES)
>              return -1;

Bad indentation.

I didn't check the rest of your patches for this, so you should skim
them...

-- 
Hollis Blanchard
IBM Linux Technology Center