From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IprA7-000733-Ck for qemu-devel@nongnu.org; Wed, 07 Nov 2007 15:06:07 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IprA4-00071I-IR for qemu-devel@nongnu.org; Wed, 07 Nov 2007 15:06:06 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IprA4-000715-1h for qemu-devel@nongnu.org; Wed, 07 Nov 2007 15:06:04 -0500 Received: from e34.co.us.ibm.com ([32.97.110.152]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IprA4-0002pb-40 for qemu-devel@nongnu.org; Wed, 07 Nov 2007 15:06:04 -0500 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e34.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id lA7K2M2v012150 for ; Wed, 7 Nov 2007 15:02:22 -0500 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id lA7K2I7e032152 for ; Wed, 7 Nov 2007 13:02:19 -0700 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lA7K2H0u027343 for ; Wed, 7 Nov 2007 13:02:18 -0700 From: Hollis Blanchard In-Reply-To: References: Content-Type: text/plain Date: Wed, 07 Nov 2007 14:01:32 -0600 Message-Id: <1194465692.32757.2.camel@basalt> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [kvm-devel] [PATCH 1/2] KVM userspace: Add PCI device passthrough support Reply-To: Hollis Blanchard , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org I'm sorry these comments aren't substantive, but please watch your whitespace... On Wed, 2007-11-07 at 21:45 +0200, Amit Shah wrote: > diff --git a/qemu/Makefile b/qemu/Makefile > index 053c88c..3e599f3 100644 > --- a/qemu/Makefile > +++ b/qemu/Makefile > @@ -37,7 +37,7 @@ qemu-img$(EXESUF): qemu-img.c cutils.c block.c > block-raw.c block-cow.c block-qco > dyngen$(EXESUF): dyngen.c > $(HOST_CC) $(CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -o $@ $^ > > -clean: > +clean: > # avoid old build problems by removing potentially incorrect old > files > rm -f config.mak config.h op-i386.h opc-i386.h gen-op-i386.h > op-arm.h opc-arm.h gen-op-arm.h > rm -f *.o *.a $(TOOLS) dyngen$(EXESUF) TAGS cscope.* *.pod *~ > */*~ Extra space. > @@ -88,8 +88,8 @@ endif > test speed test2: all > $(MAKE) -C tests $@ > > -TAGS: > - etags *.[ch] tests/*.[ch] > +TAGS: > + etags *.[ch] tests/*.[ch] hw/passthrough/*.[ch] > > cscope: > rm -f ./cscope.* Another extra space. > diff --git a/qemu/exec.c b/qemu/exec.c > index 3e588d5..7a21ca5 100644 > --- a/qemu/exec.c > +++ b/qemu/exec.c > @@ -2484,6 +2484,7 @@ int cpu_register_io_memory(int io_index, > if (io_mem_nb >= IO_MEM_NB_ENTRIES) > return -1; > io_index = io_mem_nb++; > + fprintf(stderr, "iomem index %d out of %d\n", io_index, > IO_MEM_NB_ENTRIES); > } else { > if (io_index >= IO_MEM_NB_ENTRIES) > return -1; Bad indentation. I didn't check the rest of your patches for this, so you should skim them... -- Hollis Blanchard IBM Linux Technology Center