From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IrcH8-0008Ta-Ft for qemu-devel@nongnu.org; Mon, 12 Nov 2007 11:36:38 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IrcH6-0008Qm-Tn for qemu-devel@nongnu.org; Mon, 12 Nov 2007 11:36:38 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IrcH6-0008Qd-MF for qemu-devel@nongnu.org; Mon, 12 Nov 2007 11:36:36 -0500 Received: from ecfrec.frec.bull.fr ([129.183.4.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IrcH6-000264-6b for qemu-devel@nongnu.org; Mon, 12 Nov 2007 11:36:36 -0500 Subject: Re: [Qemu-devel] [PATCH 1/2][UPDATE] remove unused parameters from QEMUMachineInitFunc From: Laurent Vivier In-Reply-To: References: <1194879921645@bull.net> <1194879921937@bull.net> Date: Mon, 12 Nov 2007 17:36:09 +0100 Message-Id: <1194885369.8525.5.camel@frecb07144> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-5JXOGRa9tReI5Vyd/wrA" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: "qemu-devel@nongnu.org" --=-5JXOGRa9tReI5Vyd/wrA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Le lundi 12 novembre 2007 =C3=A0 18:23 +0200, Blue Swirl a =C3=A9crit : > On 11/12/07, Laurent Vivier wrote: > > > > It appears that fd_filename and snapshot are not needed/used by machine > > init functions (QEMUMachineInitFunc). > > > > This patch removes them. >=20 > I don't know what was the idea for these parameters, so I can't > comment on the correctness of the patch in general. fd_filename cannot be managed because I suppressed the array in vl.c and Fabrice (when he commented the first revision of this patch) proposed to remove "snapshot" too: "- While modifying the machine init function, you can suppress the snapshot parameter." > > /* SPARCstation 5 hardware initialisation */ > > -static void ss5_init(int RAM_size, int vga_ram_size, const char *boot_= device, > > - DisplayState *ds, const char **fd_filename, int= snapshot, > > +static void ss5_init(int RAM_size, int vga_ram_size, > > + const char *boot_device, DisplayState *ds, > > const char *kernel_filename, const char *kernel= _cmdline, > > const char *initrd_filename, const char *cpu_mo= del) > > { > > @@ -616,8 +616,8 @@ static void ss5_init(int RAM_size, int v > > } > > > > /* SPARCstation 10 hardware initialisation */ > > -static void ss10_init(int RAM_size, int vga_ram_size, const char *boot= _device, > > - DisplayState *ds, const char **fd_filename= , int snapshot, > > +static void ss10_init(int RAM_size, int vga_ram_size, > > + const char *boot_device, DisplayState *ds, > > const char *kernel_filename, const char *k= ernel_cmdline, > > const char *initrd_filename, const char *c= pu_model) >=20 > You didn't fix ss600mp_init, which was added yesterday. Oops, sorry, I missed it. Thank you for your comments, Laurent --=20 ------------- Laurent.Vivier@bull.net -------------- "In short: just say NO TO DRUGS and maybe you won't end up like the Hurd people." -- Linus Torvald --=-5JXOGRa9tReI5Vyd/wrA Content-Type: application/pgp-signature; name=signature.asc Content-Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBHOID59Kffa9pFVzwRAtDLAJ9+nE9+Cj4N7yI6bu8XPu0CR3RzEgCfV/UC /PD3tMHW1tjvQqdTJyvUFOQ= =FwSy -----END PGP SIGNATURE----- --=-5JXOGRa9tReI5Vyd/wrA--