From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Is3DQ-0000vq-7w for qemu-devel@nongnu.org; Tue, 13 Nov 2007 16:22:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Is3DO-0000uj-D0 for qemu-devel@nongnu.org; Tue, 13 Nov 2007 16:22:35 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Is3DO-0000uc-4Z for qemu-devel@nongnu.org; Tue, 13 Nov 2007 16:22:34 -0500 Received: from ecfrec.frec.bull.fr ([129.183.4.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Is3DN-0007KT-Dd for qemu-devel@nongnu.org; Tue, 13 Nov 2007 16:22:33 -0500 Subject: Re: [Qemu-devel] [PATCH 2/2][UPDATE] Add arg -drive to define new drive with more features From: Laurent Vivier In-Reply-To: References: <1194879921937@bull.net> <11948799213737@bull.net> <1194969743.3673.11.camel@frecb07144> Date: Tue, 13 Nov 2007 22:22:05 +0100 Message-Id: <1194988925.3644.7.camel@frecb07144> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-wbsHmzKtk+qeK1gU6918" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl --=-wbsHmzKtk+qeK1gU6918 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le mardi 13 novembre 2007 =C3=A0 22:50 +0200, Blue Swirl a =C3=A9crit : > On 11/13/07, Laurent Vivier wrote: > > Attached is an updated patch (corrected as you want and with more check > > on -drive arguments) >=20 > Sparc64 didn't compile until I added a MAX_IDE_BUS #define. >=20 Right. Do you know why "make" doesn't compile "hw/sun4u.c" ? > SS-600MP case is still missing from vl.c and the -drive help text is > longer than 80 chars. I missed it should use SCSI by default. Corrected. I've corrected help text too. > I'd prefer a space after 'for' and 'if', though these styles aren't > very consistently used in the original files. I prefer too, but when I modify a file I take the style I find around the lines I modify... > Good news is that after adding the #define, patched Qemu seems to > work. I tested briefly both Sparc32 and Sparc64. Great. Thank you for your help, Laurent --=20 ------------- Laurent.Vivier@bull.net -------------- "Any sufficiently advanced technology is indistinguishable from magic." - Arthur C. Clarke --=-wbsHmzKtk+qeK1gU6918 Content-Type: application/pgp-signature; name=signature.asc Content-Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBHOhV99Kffa9pFVzwRAkU1AKDQa2zYx8D+DH4ox63Ko95C04/sywCg0efR 5dMhccl3IA56SDJAYhFkFuM= =O/lf -----END PGP SIGNATURE----- --=-wbsHmzKtk+qeK1gU6918--