From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IsL3t-0004s1-HB for qemu-devel@nongnu.org; Wed, 14 Nov 2007 11:25:57 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IsL3r-0004qx-0a for qemu-devel@nongnu.org; Wed, 14 Nov 2007 11:25:57 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IsL3q-0004qe-Mj for qemu-devel@nongnu.org; Wed, 14 Nov 2007 11:25:54 -0500 Received: from honiara.magic.fr ([195.154.193.36]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IsL3p-0008BM-PK for qemu-devel@nongnu.org; Wed, 14 Nov 2007 11:25:54 -0500 Subject: Re: [Qemu-devel] [PATCH] target_posix_types.h From: Jocelyn Mayer In-Reply-To: <1195055987.918.34.camel@phantasm.home.enterpriseandprosperity.com> References: <1195055987.918.34.camel@phantasm.home.enterpriseandprosperity.com> Content-Type: text/plain Date: Wed, 14 Nov 2007 17:25:46 +0100 Message-Id: <1195057546.21958.56.camel@jma4.dev.netgem.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: l_indien@magic.fr, qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: thayne@c2.net, qemu-devel@nongnu.org On Wed, 2007-11-14 at 08:59 -0700, Thayne Harbaugh wrote: > This patch, 44_target_posix_types.patch provides target specific posix > types. These types improve target structure creation, code similarity > to kernel code and improve type casting for assignment between target > and host. Hi, This seems not OK for ppc/ppc64. There is no ppc64 subdirectory anymore in the linux-user directory. ppc and ppc64 targets have been merged, as it is in recent kernels, so all the definitions should go in the ppc subdirectory, using #ifdef TARGET_PPC64 when there are differences; but there should be very few: there are only 2 ifdef __powerpc64__ in the linux-2.6.23/include/asm-powerpc/posix_types.h file. -- Jocelyn Mayer