From: Laurent Vivier <Laurent.Vivier@bull.net>
To: Samuel Thibault <samuel.thibault@eu.citrix.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive"
Date: Wed, 28 Nov 2007 16:00:17 +0100 [thread overview]
Message-ID: <1196262017.4466.2.camel@frecb07144> (raw)
In-Reply-To: <20071128142409.GF4083@implementation.uk.xensource.com>
[-- Attachment #1: Type: text/plain, Size: 839 bytes --]
Le mercredi 28 novembre 2007 à 14:24 +0000, Samuel Thibault a écrit :
> Hi,
>
> Laurent Vivier, le Wed 28 Nov 2007 15:02:50 +0100, a écrit :
> > + ret = posix_memalign((void**)&buf, 0x200, 512);
>
> For making this more easily portable, maybe it should be a new
> qemu_memalign() function? Also, the alignment may probably be better as
> a global macro, since the alignment requirements depend on the OS.
I think O_DIRECT is linux specific whereas posix_memalign() is part of
POSIX specification. And the memory alignement should only needed by the
implemetation of O_DIRECT on linux.
But I have nothing against to write a qemu_memalign().
Laurent
--
------------- Laurent.Vivier@bull.net --------------
"Any sufficiently advanced technology is
indistinguishable from magic." - Arthur C. Clarke
[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-11-28 15:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 14:02 [Qemu-devel] [PATCH 0/2] Open disk images with O_DIRECT Laurent Vivier
2007-11-28 14:02 ` [Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive" Laurent Vivier
2007-11-28 14:02 ` [Qemu-devel] [PATCH 2/2] Direct IDE I/O Laurent Vivier
2007-11-28 14:24 ` [Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive" Samuel Thibault
2007-11-28 15:00 ` Laurent Vivier [this message]
2007-11-28 15:08 ` Samuel Thibault
2007-11-29 9:40 ` Laurent Vivier
2007-11-28 14:27 ` [Qemu-devel] [PATCH 0/2] Open disk images with O_DIRECT Daniel P. Berrange
2007-11-28 14:34 ` Samuel Thibault
2007-11-28 14:58 ` Anthony Liguori
2007-11-28 15:08 ` Daniel P. Berrange
2007-11-28 15:17 ` Samuel Thibault
-- strict thread matches above, loose matches on Subject: below --
2007-11-29 17:03 [Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive" Balazs Attila-Mihaly (Cd-MaN)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196262017.4466.2.camel@frecb07144 \
--to=laurent.vivier@bull.net \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).