From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IxOQO-0002e5-Br
	for qemu-devel@nongnu.org; Wed, 28 Nov 2007 10:02:04 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IxOQN-0002d7-EK
	for qemu-devel@nongnu.org; Wed, 28 Nov 2007 10:02:03 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IxOQN-0002cy-7O
	for qemu-devel@nongnu.org; Wed, 28 Nov 2007 10:02:03 -0500
Received: from ecfrec.frec.bull.fr ([129.183.4.8])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Laurent.Vivier@bull.net>) id 1IxOQM-0007zw-MN
	for qemu-devel@nongnu.org; Wed, 28 Nov 2007 10:02:03 -0500
Subject: Re: [Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive"
From: Laurent Vivier <Laurent.Vivier@bull.net>
In-Reply-To: <20071128142409.GF4083@implementation.uk.xensource.com>
References: <11962585701617@bull.net> <1196258570752@bull.net>
	<20071128142409.GF4083@implementation.uk.xensource.com>
Date: Wed, 28 Nov 2007 16:00:17 +0100
Message-Id: <1196262017.4466.2.camel@frecb07144>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-Ec00ZoURBeUYcldZQynR"
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@eu.citrix.com>
Cc: qemu-devel@nongnu.org


--=-Ec00ZoURBeUYcldZQynR
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Le mercredi 28 novembre 2007 =C3=A0 14:24 +0000, Samuel Thibault a =C3=A9cr=
it :
> Hi,
>=20
> Laurent Vivier, le Wed 28 Nov 2007 15:02:50 +0100, a =C3=A9crit :
> > +    ret =3D posix_memalign((void**)&buf, 0x200, 512);
>=20
> For making this more easily portable, maybe it should be a new
> qemu_memalign() function?  Also, the alignment may probably be better as
> a global macro, since the alignment requirements depend on the OS.

I think O_DIRECT is linux specific whereas posix_memalign() is part of
POSIX specification. And the memory alignement should only needed by the
implemetation of O_DIRECT on linux.

But I have nothing against to write a qemu_memalign().

Laurent
--=20
------------- Laurent.Vivier@bull.net  --------------
       "Any sufficiently advanced technology is
  indistinguishable from magic." - Arthur C. Clarke

--=-Ec00ZoURBeUYcldZQynR
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: Ceci est une partie de message
	=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBHTYKB9Kffa9pFVzwRAnSXAJ4/EaPkPxYIJq8d8NjDhtUEUXxtqACfZAX1
sICczLiJJs607ZDpoDK4swg=
=JAyI
-----END PGP SIGNATURE-----

--=-Ec00ZoURBeUYcldZQynR--