Re: [Qemu-devel] [PATCH 2/2 v2] Direct IDE I/O

[Laurent Vivier <Laurent.Vivier@bull.net>]

[-- Attachment #1: Type: text/plain, Size: 1079 bytes --]

Le lundi 03 décembre 2007 à 11:23 +0100, Fabrice Bellard a écrit :
> Laurent Vivier wrote:
> > This patch enhances the "-drive ,cache=off" mode with IDE drive emulation
> > by removing the buffer used in the IDE emulation.
> > ---
> >  block.c     |   10 +++
> >  block.h     |    2 
> >  block_int.h |    1 
> >  cpu-all.h   |    1 
> >  exec.c      |   19 ++++++
> >  hw/ide.c    |  176 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
> >  vl.c        |    1 
> >  7 files changed, 204 insertions(+), 6 deletions(-)
> 
> What's the use of keeping the buffered case ?

Well, I don't like to remove code written by others...
and I don't want to break something.

But if you think I should remove the buffered case, I can.

BTW, do you think I should enable "cache=off" by default ?
Or even remove the option from the command line and always use
O_DIRECT ?

Regards,
Laurent
-- 
------------- Laurent.Vivier@bull.net  --------------
       "Any sufficiently advanced technology is
  indistinguishable from magic." - Arthur C. Clarke

[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 189 bytes --]