From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Iz8ZB-0002qH-VB
	for qemu-devel@nongnu.org; Mon, 03 Dec 2007 05:30:22 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Iz8Z9-0002lq-Jb
	for qemu-devel@nongnu.org; Mon, 03 Dec 2007 05:30:21 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Iz8Z9-0002lf-Bc
	for qemu-devel@nongnu.org; Mon, 03 Dec 2007 05:30:19 -0500
Received: from ecfrec.frec.bull.fr ([129.183.4.8])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Laurent.Vivier@bull.net>) id 1Iz8Z8-00088E-OX
	for qemu-devel@nongnu.org; Mon, 03 Dec 2007 05:30:19 -0500
Subject: Re: [Qemu-devel] [PATCH 2/2 v2] Direct IDE I/O
From: Laurent Vivier <Laurent.Vivier@bull.net>
In-Reply-To: <4753D920.4060500@bellard.org>
References: <11966765602186@bull.net>  <4753D920.4060500@bellard.org>
Date: Mon, 03 Dec 2007 11:30:04 +0100
Message-Id: <1196677804.5275.5.camel@frecb07144>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-rCxOITYWylYpJzQEwUgL"
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabrice Bellard <fabrice@bellard.org>
Cc: qemu-devel@nongnu.org


--=-rCxOITYWylYpJzQEwUgL
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Le lundi 03 d=C3=A9cembre 2007 =C3=A0 11:23 +0100, Fabrice Bellard a =C3=A9=
crit :
> Laurent Vivier wrote:
> > This patch enhances the "-drive ,cache=3Doff" mode with IDE drive emula=
tion
> > by removing the buffer used in the IDE emulation.
> > ---
> >  block.c     |   10 +++
> >  block.h     |    2=20
> >  block_int.h |    1=20
> >  cpu-all.h   |    1=20
> >  exec.c      |   19 ++++++
> >  hw/ide.c    |  176 +++++++++++++++++++++++++++++++++++++++++++++++++++=
++++++---
> >  vl.c        |    1=20
> >  7 files changed, 204 insertions(+), 6 deletions(-)
>=20
> What's the use of keeping the buffered case ?

Well, I don't like to remove code written by others...
and I don't want to break something.

But if you think I should remove the buffered case, I can.

BTW, do you think I should enable "cache=3Doff" by default ?
Or even remove the option from the command line and always use
O_DIRECT ?

Regards,
Laurent
--=20
------------- Laurent.Vivier@bull.net  --------------
       "Any sufficiently advanced technology is
  indistinguishable from magic." - Arthur C. Clarke

--=-rCxOITYWylYpJzQEwUgL
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: Ceci est une partie de message
	=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBHU9qs9Kffa9pFVzwRAp90AJ9YwtKCgN+rHQzb2wfZJPW25AROEgCfdNUc
zfszb86EDWB24UTxfDzuUoQ=
=NKji
-----END PGP SIGNATURE-----

--=-rCxOITYWylYpJzQEwUgL--