From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IzU5W-0007PM-Sv for qemu-devel@nongnu.org; Tue, 04 Dec 2007 04:29:11 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IzU5T-0007J3-Nh for qemu-devel@nongnu.org; Tue, 04 Dec 2007 04:29:10 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IzU5T-0007Ih-HM for qemu-devel@nongnu.org; Tue, 04 Dec 2007 04:29:07 -0500 Received: from ecfrec.frec.bull.fr ([129.183.4.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IzU5S-0002gg-T9 for qemu-devel@nongnu.org; Tue, 04 Dec 2007 04:29:07 -0500 Received: from localhost (localhost [127.0.0.1]) by ecfrec.frec.bull.fr (Postfix) with ESMTP id AA57A19D93C for ; Tue, 4 Dec 2007 10:29:01 +0100 (CET) Received: from ecfrec.frec.bull.fr ([127.0.0.1]) by localhost (ecfrec.frec.bull.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 09093-05 for ; Tue, 4 Dec 2007 10:28:58 +0100 (CET) Received: from ecn002.frec.bull.fr (ecn002.frec.bull.fr [129.183.4.6]) by ecfrec.frec.bull.fr (Postfix) with ESMTP id DEDAE19D90D for ; Tue, 4 Dec 2007 10:28:57 +0100 (CET) Subject: Re: [Qemu-devel] qemu vl.c hw/omap.c From: Laurent Vivier In-Reply-To: <200712040120.26286.paul@codesourcery.com> References: <200712040102.03664.paul@codesourcery.com> <200712040120.26286.paul@codesourcery.com> Date: Tue, 04 Dec 2007 10:28:49 +0100 Message-Id: <1196760529.4095.10.camel@frecb07144> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-wl1+6bo5VVdt7BrjVL5J" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --=-wl1+6bo5VVdt7BrjVL5J Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le mardi 04 d=C3=A9cembre 2007 =C3=A0 01:20 +0000, Paul Brook a =C3=A9crit = : > On Tuesday 04 December 2007, andrzej zaborowski wrote: > > On 04/12/2007, Paul Brook wrote: > > > > Log message: > > > > Always create an SD bdrv, so that PXA and OMAP boards can boo= t > > > > with no card inserted again. Eventually SD, CDROM and floppy shoul= d > > > > all be registered conditionally depending on machine. > > > > > > This seems the wrong way to solve this problem. The SD emulation shou= ld > > > be able to cope with no device being present. > > > > The bdrv's represent the concept of "drive" rather than "media", and > > also in the case the bdrv must be present whenever there is a SD slot, > > not an SD card (so that monitor command change and eject can be used). > > I agree that not all machines have an SD slot, as not all machines > > have a cd-rom drive or floppy drive. >=20 > Right, but I think you're going in the wrong direction. Most scsi interfa= ces=20 > do support hotplug of devices. For USB mass storage the whole controller = is=20 > hotplug. Pre-allocating all possible devices simply doesn't scale. Hi Paul, I think Andrzez is doing it correctly. He only adds an entry in drives_table[] without creating any bdrv (because he doesn't provide file). Then in omap.c, he creates the device, not the media. And as Palm Tunsgten is the only machine calling omap310_mpu_init(), the device is only created for it. And then he will be able to introduce card (file) in the SD reader. Laurent --=20 ------------- Laurent.Vivier@bull.net -------------- "Any sufficiently advanced technology is indistinguishable from magic." - Arthur C. Clarke --=-wl1+6bo5VVdt7BrjVL5J Content-Type: application/pgp-signature; name=signature.asc Content-Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBHVR3R9Kffa9pFVzwRAo/JAJ9yfncPRI/oc1/ws5T5K1YVStcj5wCdHZep W1VXDn6I4FYCf7Fb2XdIO4Q= =xNnv -----END PGP SIGNATURE----- --=-wl1+6bo5VVdt7BrjVL5J--