From: Jocelyn Mayer <l_indien@magic.fr>
To: claude vittoria <vittoric@wanadoo.fr>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PPC] FPIMM macro and mtfsfi instruction
Date: Mon, 17 Dec 2007 18:32:27 +0100 [thread overview]
Message-ID: <1197912747.19838.31.camel@jma4.dev.netgem.com> (raw)
In-Reply-To: <15604398.56931197903176591.JavaMail.www@wwinf1607>
On Mon, 2007-12-17 at 15:52 +0100, claude vittoria wrote:
> Hi everybody,
>
> I think that I get a wrong result with mtfsfi instruction.
>
> I think to get a solution, see below.
> Could you confirm my opinion ?
Seems there have been (once again) a confusion between IBM bit notation
(0 is MSB...) and standard one. You're right, FPIMM should be taken
using EXTRACT_HELPER(FPIMM, 12, 4);
Thanks for the report.
> translate.c
> l344:EXTRACT_HELPER(crbD, 21, 5);
> ...
> l375:EXTRACT_HELPER(FPIMM, 20, 4); <======FPIMM must be (FPIMM, 12, 4) or crbB >> 1 for mtfsfi; IMM is bits[16-19] of the instruction in PPC programming environnement 32bit (p8-135). IMM is not one bit before crbD.
> ...
[...]
--
Jocelyn Mayer <l_indien@magic.fr>
next prev parent reply other threads:[~2007-12-17 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 14:52 [Qemu-devel] [PPC] FPIMM macro and mtfsfi instruction claude vittoria
2007-12-17 17:32 ` Jocelyn Mayer [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-12-18 8:49 claude vittoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197912747.19838.31.camel@jma4.dev.netgem.com \
--to=l_indien@magic.fr \
--cc=qemu-devel@nongnu.org \
--cc=vittoric@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).