From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J4Joj-0006N1-0O for qemu-devel@nongnu.org; Mon, 17 Dec 2007 12:31:49 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J4Joh-0006Ml-80 for qemu-devel@nongnu.org; Mon, 17 Dec 2007 12:31:48 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J4Joh-0006MR-3F for qemu-devel@nongnu.org; Mon, 17 Dec 2007 12:31:47 -0500 Received: from bangui.magic.fr ([195.154.194.245]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1J4Jog-0005E3-8K for qemu-devel@nongnu.org; Mon, 17 Dec 2007 12:31:46 -0500 Subject: Re: [Qemu-devel] [PPC] FPIMM macro and mtfsfi instruction From: Jocelyn Mayer In-Reply-To: <15604398.56931197903176591.JavaMail.www@wwinf1607> References: <15604398.56931197903176591.JavaMail.www@wwinf1607> Content-Type: text/plain Date: Mon, 17 Dec 2007 18:32:27 +0100 Message-Id: <1197912747.19838.31.camel@jma4.dev.netgem.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: l_indien@magic.fr, qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: claude vittoria , qemu-devel@nongnu.org On Mon, 2007-12-17 at 15:52 +0100, claude vittoria wrote: > Hi everybody, > > I think that I get a wrong result with mtfsfi instruction. > > I think to get a solution, see below. > Could you confirm my opinion ? Seems there have been (once again) a confusion between IBM bit notation (0 is MSB...) and standard one. You're right, FPIMM should be taken using EXTRACT_HELPER(FPIMM, 12, 4); Thanks for the report. > translate.c > l344:EXTRACT_HELPER(crbD, 21, 5); > ... > l375:EXTRACT_HELPER(FPIMM, 20, 4); <======FPIMM must be (FPIMM, 12, 4) or crbB >> 1 for mtfsfi; IMM is bits[16-19] of the instruction in PPC programming environnement 32bit (p8-135). IMM is not one bit before crbD. > ... [...] -- Jocelyn Mayer