From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD77C56202 for ; Fri, 13 Nov 2020 19:33:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A454C2085B for ; Fri, 13 Nov 2020 19:33:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IiOIJV9G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A454C2085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdepV-000329-IB for qemu-devel@archiver.kernel.org; Fri, 13 Nov 2020 14:33:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdeoM-0002Ky-Bb for qemu-devel@nongnu.org; Fri, 13 Nov 2020 14:32:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:36589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kdeoH-0000I6-CJ for qemu-devel@nongnu.org; Fri, 13 Nov 2020 14:32:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605295955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tD+hIRJwAqUQ8+0eGS20lhNxCBzUbPKDJmHbw/IbpuA=; b=IiOIJV9Ga+toVJqPLtg+7T24mLvH2Q/M6I2393bK7HQC296M6f4NYGUCeYJoGTqEaBUA+f HJqBQC4Qcu8iftbRnmjexFmDbdr/rWE/HV8Tk6h3rD8fHGWmqSzJtfxLSm7o8QLugJsG59 DfTsDzSZer6P+Ir8MxT1TXxdVdFp0Zc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-70-IRvTeL3IOFunW5soEFiZDg-1; Fri, 13 Nov 2020 14:32:32 -0500 X-MC-Unique: IRvTeL3IOFunW5soEFiZDg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D0C9F5F9E2; Fri, 13 Nov 2020 19:32:30 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-114-96.ams2.redhat.com [10.36.114.96]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 10DBE1002382; Fri, 13 Nov 2020 19:32:24 +0000 (UTC) Subject: Re: [PATCH v7 21/21] scripts/simplebench: add bench_prealloc.py To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20201021145859.11201-1-vsementsov@virtuozzo.com> <20201021145859.11201-22-vsementsov@virtuozzo.com> <7ac2a1e3-19a3-5d84-49fc-369f8ac2b696@redhat.com> <6ecf486b-3faa-c940-5923-746f71a5cd29@virtuozzo.com> From: Max Reitz Message-ID: <1198adee-f7b7-79b2-904c-39d16f290547@redhat.com> Date: Fri, 13 Nov 2020 20:32:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <6ecf486b-3faa-c940-5923-746f71a5cd29@virtuozzo.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 16:09:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, den@virtuozzo.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 13.11.20 19:00, Vladimir Sementsov-Ogievskiy wrote: > 13.11.2020 19:24, Max Reitz wrote: >> On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: >>> Benchmark for new preallocate filter. >>> >>> Example usage: >>>      ./bench_prealloc.py ../../build/qemu-img \ >>>          ssd-ext4:/path/to/mount/point \ >>>          ssd-xfs:/path2 hdd-ext4:/path3 hdd-xfs:/path4 >>> >>> The benchmark shows performance improvement (or degradation) when use >>> new preallocate filter with qcow2 image. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>>   scripts/simplebench/bench_prealloc.py | 132 ++++++++++++++++++++++++++ >>>   1 file changed, 132 insertions(+) >>>   create mode 100755 scripts/simplebench/bench_prealloc.py >> >> Reviewed-by: Max Reitz >> > > > Thanks for reviewing! Could you take this all through you tree? Sure, if you can live with the fact that I’ll be on PTO for the next two weeks :) (Shouldn’t matter for block-next, as 5.2 won’t be released until December.) Max