From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JCXn8-0006gb-1w for qemu-devel@nongnu.org; Wed, 09 Jan 2008 05:04:10 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JCXn6-0006fE-7o for qemu-devel@nongnu.org; Wed, 09 Jan 2008 05:04:09 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JCXn5-0006ez-RE for qemu-devel@nongnu.org; Wed, 09 Jan 2008 05:04:07 -0500 Received: from ecfrec.frec.bull.fr ([129.183.4.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JCXn5-0002La-14 for qemu-devel@nongnu.org; Wed, 09 Jan 2008 05:04:07 -0500 Subject: Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows From: Laurent Vivier In-Reply-To: <1199871092.4337.4.camel@frecb07144> References: <1199871092.4337.4.camel@frecb07144> Date: Wed, 09 Jan 2008 11:04:29 +0100 Message-Id: <1199873069.4337.20.camel@frecb07144> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-nYEl2B/woU9dk72tiwU1" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?ISO-8859-1?Q?Herv=E9?= Poussineau --=-nYEl2B/woU9dk72tiwU1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le mercredi 09 janvier 2008 =C3=A0 10:31 +0100, Laurent Vivier a =C3=A9crit= :=20 > Le mardi 08 janvier 2008 =C3=A0 17:17 +0100, Herv=C3=A9 Poussineau a =C3= =A9crit : > > Hi, > > =20 > > On Windows, since December 2nd, files names provided in command line=20 > > have to double their backslash to work correctly, for example: "-hda=20 > > c:\\disks\\qemu.qcow" instead of -hda c:\disks\qemu.qcow" > > This patch removes this need and reverts back to Qemu 0.9.0 behaviour > > =20 > > Herv=C3=A9 > >=20 >=20 > I have introduced this behavior to be able to use command line like > "qemu -hda my\ file", IMHO your patch should be #ifdef for window only. In fact, this is a wrong example, this case is managed by the shell. A good example is when we have a filename with a '"' in it: qemu -hda 2\\\"file to open file 2"file Laurent --=20 ----------------- Laurent.Vivier@bull.net ------------------ "La perfection est atteinte non quand il ne reste rien =C3=A0 ajouter mais quand il ne reste rien =C3=A0 enlever." Saint Exup=C3=A9ry --=-nYEl2B/woU9dk72tiwU1 Content-Type: application/pgp-signature; name=signature.asc Content-Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBHhJwt9Kffa9pFVzwRAvaKAKCNuUj6P9xtuQD8i1Pzk3fubsuxBwCdFV6D O+ITIvp8ijAy/DLws4JciZ8= =lAGc -----END PGP SIGNATURE----- --=-nYEl2B/woU9dk72tiwU1--