From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JCaOw-0007hQ-Fe for qemu-devel@nongnu.org; Wed, 09 Jan 2008 07:51:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JCaOu-0007gP-WC for qemu-devel@nongnu.org; Wed, 09 Jan 2008 07:51:21 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JCaOu-0007gI-I9 for qemu-devel@nongnu.org; Wed, 09 Jan 2008 07:51:20 -0500 Received: from ecfrec.frec.bull.fr ([129.183.4.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JCaOt-0006Gy-UV for qemu-devel@nongnu.org; Wed, 09 Jan 2008 07:51:20 -0500 Subject: Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows From: Laurent Vivier In-Reply-To: References: <1199871092.4337.4.camel@frecb07144> <1199873069.4337.20.camel@frecb07144> <1199880481.4337.31.camel@frecb07144> Date: Wed, 09 Jan 2008 13:51:38 +0100 Message-Id: <1199883098.4337.42.camel@frecb07144> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-SlqMZUXhow4zHFgE0+Ht" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Johannes Schindelin Cc: =?ISO-8859-1?Q?Herv=E9?= Poussineau , qemu-devel@nongnu.org --=-SlqMZUXhow4zHFgE0+Ht Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le mercredi 09 janvier 2008 =C3=A0 12:27 +0000, Johannes Schindelin a =C3= =A9crit : > Hi, >=20 > On Wed, 9 Jan 2008, Laurent Vivier wrote: >=20 > > but "-hda" is an alias for "-drive file=3D"%s",index=3D%d,media=3Ddisk"= . >=20 > It appears to me as if "-hda" is implemented suboptimally, then. In=20 > particular, drive_add() should be able to get a separate "file" parameter= ,=20 > which can be overridden by the "fmt" parameter. Of course, this would=20 > mean that the global drives_opt[] array should not have element type=20 > "char", but a struct. This introduces complexity and special cases I don't want to manage... > It is a pity that there is DWIMery going on in drive_init(), needing the=20 > other options to be parsed already, otherwise drive_add() could have been= =20 > replaced by calls to drive_init(). I just mimic here already existing behavior of qemu. drive_init() already parse parameter to extract options. You can't make drive_init() before having parsed all parameters because of parameters like "-hda f -hdachs x,y,z" Regards, Laurent --=20 ----------------- Laurent.Vivier@bull.net ------------------ "La perfection est atteinte non quand il ne reste rien =C3=A0 ajouter mais quand il ne reste rien =C3=A0 enlever." Saint Exup=C3=A9ry --=-SlqMZUXhow4zHFgE0+Ht Content-Type: application/pgp-signature; name=signature.asc Content-Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBHhMNa9Kffa9pFVzwRAkJKAJ9uByK07eF1xLCXtWFIHTtJdD1HvQCfTE7E kjEa7wjrkF4HdypL5/Lq9eU= =A4/z -----END PGP SIGNATURE----- --=-SlqMZUXhow4zHFgE0+Ht--