From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JCbFx-0000kn-Ko for qemu-devel@nongnu.org; Wed, 09 Jan 2008 08:46:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JCbFw-0000jC-H3 for qemu-devel@nongnu.org; Wed, 09 Jan 2008 08:46:09 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JCbFw-0000io-Cm for qemu-devel@nongnu.org; Wed, 09 Jan 2008 08:46:08 -0500 Received: from ecfrec.frec.bull.fr ([129.183.4.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JCbFv-0002Dv-Le for qemu-devel@nongnu.org; Wed, 09 Jan 2008 08:46:08 -0500 Subject: Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows From: Laurent Vivier In-Reply-To: References: <1199871092.4337.4.camel@frecb07144> <1199873069.4337.20.camel@frecb07144> <1199880481.4337.31.camel@frecb07144> <1199883098.4337.42.camel@frecb07144> Date: Wed, 09 Jan 2008 14:46:32 +0100 Message-Id: <1199886392.4337.52.camel@frecb07144> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-vxXJu2IloKUu2u+qnlkm" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?ISO-8859-1?Q?Herv=E9?= Poussineau --=-vxXJu2IloKUu2u+qnlkm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le mercredi 09 janvier 2008 =C3=A0 13:27 +0000, Johannes Schindelin a =C3= =A9crit : > Hi, >=20 > On Wed, 9 Jan 2008, Laurent Vivier wrote: >=20 > > Le mercredi 09 janvier 2008 =C3=A0 12:27 +0000, Johannes Schindelin a = =C3=A9crit : > >=20 > > > On Wed, 9 Jan 2008, Laurent Vivier wrote: > > >=20 > > > > but "-hda" is an alias for "-drive file=3D"%s",index=3D%d,media=3Dd= isk". > > >=20 > > > It appears to me as if "-hda" is implemented suboptimally, then. In=20 > > > particular, drive_add() should be able to get a separate "file"=20 > > > parameter, which can be overridden by the "fmt" parameter. Of course= ,=20 > > > this would mean that the global drives_opt[] array should not have=20 > > > element type "char", but a struct. > >=20 > > This introduces complexity and special cases I don't want to manage... >=20 > The problem is that you introduced a regression, as you can see by the=20 > size of this thread. The solution is very simple to restore original behavior: don't manage filename with spaces. Laurent --=20 ----------------- Laurent.Vivier@bull.net ------------------ "La perfection est atteinte non quand il ne reste rien =C3=A0 ajouter mais quand il ne reste rien =C3=A0 enlever." Saint Exup=C3=A9ry --=-vxXJu2IloKUu2u+qnlkm Content-Type: application/pgp-signature; name=signature.asc Content-Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBHhNA49Kffa9pFVzwRAm37AJ9eP52BJrt7RRdW50u31wWYH92sKACggO9j TnYQE3z21BeObHQT6Y8jqh8= =NUlN -----END PGP SIGNATURE----- --=-vxXJu2IloKUu2u+qnlkm--