From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JCc7h-0000Qb-Hb for qemu-devel@nongnu.org; Wed, 09 Jan 2008 09:41:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JCc7g-0000Ox-Kk for qemu-devel@nongnu.org; Wed, 09 Jan 2008 09:41:41 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JCc7g-0000Ok-GC for qemu-devel@nongnu.org; Wed, 09 Jan 2008 09:41:40 -0500 Received: from ecfrec.frec.bull.fr ([129.183.4.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JCc7f-0006QB-KL for qemu-devel@nongnu.org; Wed, 09 Jan 2008 09:41:40 -0500 Subject: Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows From: Laurent Vivier In-Reply-To: References: <1199871092.4337.4.camel@frecb07144> <1199873069.4337.20.camel@frecb07144> <1199880481.4337.31.camel@frecb07144> <1199883098.4337.42.camel@frecb07144> <1199886392.4337.52.camel@frecb07144> Date: Wed, 09 Jan 2008 15:42:02 +0100 Message-Id: <1199889722.4337.55.camel@frecb07144> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-h4X8K2En3kt+yAgczCJF" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Johannes Schindelin Cc: =?ISO-8859-1?Q?Herv=E9?= Poussineau , qemu-devel@nongnu.org --=-h4X8K2En3kt+yAgczCJF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le mercredi 09 janvier 2008 =C3=A0 13:59 +0000, Johannes Schindelin a =C3= =A9crit : > Hi, >=20 > On Wed, 9 Jan 2008, Laurent Vivier wrote: >=20 > > Le mercredi 09 janvier 2008 =C3=A0 13:27 +0000, Johannes Schindelin a = =C3=A9crit : > > > Hi, > > >=20 > > > On Wed, 9 Jan 2008, Laurent Vivier wrote: > > >=20 > > > > Le mercredi 09 janvier 2008 =C3=A0 12:27 +0000, Johannes Schindelin= a =C3=A9crit : > > > >=20 > > > > > On Wed, 9 Jan 2008, Laurent Vivier wrote: > > > > >=20 > > > > > > but "-hda" is an alias for "-drive file=3D"%s",index=3D%d,media= =3Ddisk". > > > > >=20 > > > > > It appears to me as if "-hda" is implemented suboptimally, then. = =20 > > > > > In particular, drive_add() should be able to get a separate "file= "=20 > > > > > parameter, which can be overridden by the "fmt" parameter. Of=20 > > > > > course, this would mean that the global drives_opt[] array should= =20 > > > > > not have element type "char", but a struct. > > > >=20 > > > > This introduces complexity and special cases I don't want to=20 > > > > manage... > > >=20 > > > The problem is that you introduced a regression, as you can see by th= e=20 > > > size of this thread. > >=20 > > The solution is very simple to restore original behavior: don't manage=20 > > filename with spaces. >=20 > I disagree with the term "solution" in this context. I call a thing like= =20 > this "regression". It's not a regression because originally qemu was not able to manage spaces in filename. I broke things ("\" management) by trying to manage spaces. Laurent --=20 ----------------- Laurent.Vivier@bull.net ------------------ "La perfection est atteinte non quand il ne reste rien =C3=A0 ajouter mais quand il ne reste rien =C3=A0 enlever." Saint Exup=C3=A9ry --=-h4X8K2En3kt+yAgczCJF Content-Type: application/pgp-signature; name=signature.asc Content-Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBHhN069Kffa9pFVzwRAsWSAJsE3dlHDdacuHMBnxxi4PdBp3UeIACfeZem hk5cJFNPpPIZ2jBSgMQj7uU= =MWZi -----END PGP SIGNATURE----- --=-h4X8K2En3kt+yAgczCJF--