Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

[Laurent Vivier <Laurent.Vivier@bull.net>]

[-- Attachment #1: Type: text/plain, Size: 1476 bytes --]

Le jeudi 10 janvier 2008 à 15:30 +0200, Avi Kivity a écrit :
> Johannes Schindelin wrote:
> > Hi,
> >
> > On Thu, 10 Jan 2008, Laurent Vivier wrote:
> >
> >   
> >> Perhaps the best solution is to put "file=" option at the end of 
> >> aliases, '\0' is marking the end of filename (it is likely the idea of 
> >> andrzej about special characters).
> >>     
> >
> > Oh, why not just make it a requirement that file= comes last, always?
> >
> >   
> 
> That's hardly intuitive.  I would prefer some sort of escaping for \, 
> and \=.  It will also break if/when -drive gains another filename 
> argument (say, for keeping shapshot data in).

I agree with our comments, but this not solves the original issue with
windows (double backslash).

- we can't use '\' because it force to double it for windows
- we must be able to escape characters to be able to use ',' and '=' in
filename (in fact ' ' is not an issue).

perhaps the solution is to use a different escape character ?

Do you like '^' ?

qemu -hda "my file" -> filename is "my file"
qemu -hda my^,file -> filename is "my,file"
qemu -drive file=my^^file -> filename is "my^file"

Johannes, I'm sorry, but it seems there is no other way than reparsing
(lightly) the string.
 
Laurent
-- 
----------------- Laurent.Vivier@bull.net  ------------------
  "La perfection est atteinte non quand il ne reste rien à
ajouter mais quand il ne reste rien à enlever." Saint Exupéry

[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 189 bytes --]