Re: [PATCH v4 10/15] qapi: make s390x specific CPU commands unconditionally available

[Thomas Huth <thuth@redhat.com>]

On 22/05/2025 21.05, Pierrick Bouvier wrote:
> From: Daniel P. Berrangé <berrange@redhat.com>
> 
> This removes the TARGET_S390X and CONFIG_KVM conditions from the
> CPU commands that are conceptually specific to s390x. Top level
> stubs are provided to cope with non-s390x targets, or builds
> without KVM.
> 
> The removal of CONFIG_KVM is justified by the fact there is no
> conceptual difference between running 'qemu-system-s390x -accel tcg'
> on a build with and without KVM built-in, so apps only using TCG
> can't rely on the CONFIG_KVM in the schema.
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   ...machine-target.json => machine-s390x.json} | 16 +++++---------
>   qapi/qapi-schema.json                         |  2 +-
>   include/hw/s390x/cpu-topology.h               |  2 +-
>   hw/s390x/cpu-topology.c                       |  4 ++--
>   stubs/monitor-cpu-s390x-kvm.c                 | 22 +++++++++++++++++++
>   tests/qtest/qmp-cmd-test.c                    |  1 +
>   qapi/meson.build                              |  2 +-
>   stubs/meson.build                             |  1 +
>   8 files changed, 35 insertions(+), 15 deletions(-)
>   rename qapi/{machine-target.json => machine-s390x.json} (85%)
>   create mode 100644 stubs/monitor-cpu-s390x-kvm.c

Reviewed-by: Thomas Huth <thuth@redhat.com>