From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60903)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1e1vy4-0006W5-AP
	for qemu-devel@nongnu.org; Tue, 10 Oct 2017 10:57:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1e1vy1-0002Vf-8q
	for qemu-devel@nongnu.org; Tue, 10 Oct 2017 10:57:12 -0400
References: <20171010102655.23322-1-pbonzini@redhat.com>
	<e53dac45-195e-88d2-fd50-083658cb6d4d@linaro.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <11c27aeb-2f07-665a-bb2a-1a47c46bca19@redhat.com>
Date: Tue, 10 Oct 2017 16:57:00 +0200
MIME-Version: 1.0
In-Reply-To: <e53dac45-195e-88d2-fd50-083658cb6d4d@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] build: remove CONFIG_LIBDECNUMBER
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org

On 10/10/2017 16:47, Richard Henderson wrote:
> On 10/10/2017 03:26 AM, Paolo Bonzini wrote:
>> It is used only by PPC TCG, so just move it in target/ppc/Makefile.objs
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> FWIW, it *should* be used by target/s390x as well.
> 
>> diff --git a/target/ppc/Makefile.objs b/target/ppc/Makefile.objs
>> index f92ba67ebd..ba61012bef 100644
>> --- a/target/ppc/Makefile.objs
>> +++ b/target/ppc/Makefile.objs
>> @@ -15,5 +15,10 @@ obj-y += int_helper.o
>>  obj-y += timebase_helper.o
>>  obj-y += misc_helper.o
>>  obj-y += mem_helper.o
>> +obj-y += ../../libdecnumber/decContext.o
>> +obj-y += ../../libdecnumber/decNumber.o
>> +obj-y += ../../libdecnumber/dpd/decimal32.o
>> +obj-y += ../../libdecnumber/dpd/decimal64.o
>> +obj-y += ../../libdecnumber/dpd/decimal128.o
>>  obj-$(CONFIG_USER_ONLY) += user_only_helper.o
>>  obj-y += gdbstub.o
> 
> I suppose this isn't horrible, if it needed to be replicated.

If it has to be replicated, it should be

obj-y += ../../libdecnumber/

I'll post v2.

Paolo