qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "mar.krzeminski" <mar.krzeminski@gmail.com>
To: Jean-Christophe DUBOIS <jcd@tribudubois.net>,
	qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.
Date: Tue, 3 Jan 2017 18:08:37 +0100	[thread overview]
Message-ID: <11ce9101-b01a-9d6a-4f0e-b459b5f49f0c@gmail.com> (raw)
In-Reply-To: <3f17d9af-a43f-82cb-c477-e2036ab7492a@tribudubois.net>



W dniu 02.01.2017 o 22:24, Jean-Christophe DUBOIS pisze:
> Le 30/12/2016 à 19:09, mar.krzeminski a écrit :
>>>> Can you check spi controller model code?
>>>
>>> I'll double check.
>>>
>>> But why is the SPI memory/device even responding if CS is not set ?
>> Looking at ssi code it should not.
>> Flash (so the m25p80) is responding when CS line is low and it seem 
>> that this is default.
>
> So I fixed the CS handling in the i.MX SPI device emulator and I don't 
> experience crashes anymore. Thanks for your help.

Cool!
>
> You may still want to harden the m25p80 code to make sure it doesn't 
> overrun its internal buffer.

Yeap, for me it is a bug.
I understand you will not finish this patch, won't you ?:)

Thanks,
Marcin
>
>>
>> Thanks,
>> Marcin
>>
>>>
>>>>
>>>> Thanks,
>>>> Marcin
>>>>
>>>>
>>>
>>>
>>
>>
>
>

  reply	other threads:[~2017-01-03 17:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-24 15:11 [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer Jean-Christophe Dubois
2016-12-24 17:18 ` mar.krzeminski
2016-12-24 17:41   ` Jean-Christophe DUBOIS
2016-12-24 18:04     ` mar.krzeminski
2016-12-24 18:12       ` Jean-Christophe DUBOIS
2016-12-27 17:08         ` Jean-Christophe DUBOIS
2016-12-30 15:39           ` mar.krzeminski
2016-12-30 17:14             ` Jean-Christophe DUBOIS
2016-12-30 18:09               ` mar.krzeminski
2017-01-02 21:24                 ` Jean-Christophe DUBOIS
2017-01-03 17:08                   ` mar.krzeminski [this message]
2017-01-03 20:34                     ` Jean-Christophe DUBOIS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11ce9101-b01a-9d6a-4f0e-b459b5f49f0c@gmail.com \
    --to=mar.krzeminski@gmail.com \
    --cc=jcd@tribudubois.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).