From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOSZn-00018P-Nj for qemu-devel@nongnu.org; Tue, 03 Jan 2017 12:08:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOSZk-0005v1-IJ for qemu-devel@nongnu.org; Tue, 03 Jan 2017 12:08:43 -0500 Received: from mail-wj0-x230.google.com ([2a00:1450:400c:c01::230]:35167) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cOSZk-0005ud-CG for qemu-devel@nongnu.org; Tue, 03 Jan 2017 12:08:40 -0500 Received: by mail-wj0-x230.google.com with SMTP id v7so450058520wjy.2 for ; Tue, 03 Jan 2017 09:08:40 -0800 (PST) References: <20161224151113.23955-1-jcd@tribudubois.net> <606aedd3-2f56-fb89-b547-763baf833ed5@gmail.com> <5b3ba089-e218-40ff-3b72-f31ada1e4cfc@tribudubois.net> <5f1acd02-018d-0a17-105c-cd42c50a3e91@tribudubois.net> <684d34f1-9107-1ed0-1115-f3034bd899f4@tribudubois.net> <3f17d9af-a43f-82cb-c477-e2036ab7492a@tribudubois.net> From: "mar.krzeminski" Message-ID: <11ce9101-b01a-9d6a-4f0e-b459b5f49f0c@gmail.com> Date: Tue, 3 Jan 2017 18:08:37 +0100 MIME-Version: 1.0 In-Reply-To: <3f17d9af-a43f-82cb-c477-e2036ab7492a@tribudubois.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jean-Christophe DUBOIS , qemu-devel@nongnu.org, peter.maydell@linaro.org W dniu 02.01.2017 o 22:24, Jean-Christophe DUBOIS pisze: > Le 30/12/2016 à 19:09, mar.krzeminski a écrit : >>>> Can you check spi controller model code? >>> >>> I'll double check. >>> >>> But why is the SPI memory/device even responding if CS is not set ? >> Looking at ssi code it should not. >> Flash (so the m25p80) is responding when CS line is low and it seem >> that this is default. > > So I fixed the CS handling in the i.MX SPI device emulator and I don't > experience crashes anymore. Thanks for your help. Cool! > > You may still want to harden the m25p80 code to make sure it doesn't > overrun its internal buffer. Yeap, for me it is a bug. I understand you will not finish this patch, won't you ?:) Thanks, Marcin > >> >> Thanks, >> Marcin >> >>> >>>> >>>> Thanks, >>>> Marcin >>>> >>>> >>> >>> >> >> > >