From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
keithp@keithp.com, qemu-arm@nongnu.org,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Semihosting, arm, riscv, ppc and common code
Date: Tue, 14 Jan 2020 17:25:59 +1100 [thread overview]
Message-ID: <11d88b2741eac3f634d5aed9e3355c974b533f7b.camel@kernel.crashing.org> (raw)
Hi Folks !
So I started "porting" over (read: copying) the arm semihosting code to
ppc to mimmic what Keith did for risv (mostly for picolibc support).
I noticed that the bulk of arm-semi.c (or riscv-semi.c) is trivially
made completely generic by doing a couple of changes:
- Make most functions take a CPUState instead of the architecture
specific "env"
- Provide arch helpers to retreive the op, set the result, do the
flen bug hack and possibly a couple of others (I'm not done yet).
There are other archs who do semihosting completely differently but at
least those 3 can share code.
Any objection/comment on the approach ? What I'll probably do is get
things going first with my ppc version (which I made more/less generic
but still located in target/ppc) at which point I can post an RFC so
you get an idea, and we find a good location for it.
From thre we might consider fixing some of the worst crap in there
doing backwards compatible extensions if we care enough :-)
Cheers,
Ben.
next reply other threads:[~2020-01-14 6:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 6:25 Benjamin Herrenschmidt [this message]
2020-01-14 7:32 ` Semihosting, arm, riscv, ppc and common code Liviu Ionescu
2020-01-14 7:53 ` Benjamin Herrenschmidt
2020-01-14 9:51 ` Alex Bennée
2020-01-15 1:14 ` Benjamin Herrenschmidt
2020-01-15 12:01 ` Alex Bennée
2020-01-15 12:30 ` Liviu Ionescu
2020-01-15 21:28 ` Richard Henderson
2020-01-15 22:02 ` Liviu Ionescu
2020-01-16 2:04 ` Benjamin Herrenschmidt
2020-01-16 7:57 ` Liviu Ionescu
2020-01-16 6:33 ` Benjamin Herrenschmidt
2020-01-14 9:59 ` Peter Maydell
2020-01-15 1:17 ` Benjamin Herrenschmidt
2020-01-15 13:32 ` Peter Maydell
2020-01-16 2:01 ` Benjamin Herrenschmidt
2020-01-16 11:05 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11d88b2741eac3f634d5aed9e3355c974b533f7b.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=alex.bennee@linaro.org \
--cc=keithp@keithp.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).