qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, Thomas Huth <thuth@redhat.com>
Cc: "Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Daniel P.Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH 3/4] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed)
Date: Thu, 11 Mar 2021 11:29:11 +0100	[thread overview]
Message-ID: <11dbbbed-36c2-c312-7577-c2843b4e368a@redhat.com> (raw)
In-Reply-To: <87y2euqe4j.fsf@dusky.pond.sub.org>

On 11/03/21 09:38, Markus Armbruster wrote:
> 
> If we decide we want something else, keep -usbdevice braille deprecated
> until something else is ready, then keep it deprecated for a sensible
> grace period, then remove it.  Flip-flopping deprecation in between is
> not helpful.
> 
> If we can't make up our minds, keep it deprecated until we do.
> 
> Only if we decide the sugar should remain -usbdevice braille, we should
> undeprecate it now.
> 
> The road to the CLI hell we're in is paved with "convenience".

A lot of the work I did in 6.0 on vl.c and friends was exactly to figure 
out:

- which of our CLI interfaces are a maintainability issue and really 
need deprecation

- which of our CLI interfaces can be modified to improve maintainability 
and simplify the addition of new interfaces

- how machine creation *really* works, so that it's easy to add things 
at the right spot.

Of course _everything_ is a maintenance cost, but you can at least make 
sure that the cost is not visible to most developers.  This series, as 
well as the previous removal of parameterized -usbdevice is just doing 
that: keep the decent parts that do not hamper maintainability, 
deprecate/remove the rest.

Paolo



  parent reply	other threads:[~2021-03-11 10:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 17:33 [PATCH 0/4] Clean up the -usbdevice mess Thomas Huth
2021-03-10 17:33 ` [PATCH 1/4] usb: remove support for -usbdevice parameters Thomas Huth
2021-03-10 18:19   ` Eric Blake
2021-03-10 17:33 ` [PATCH 2/4] usb: remove '-usbdevice u2f-key' Thomas Huth
2021-03-10 17:33 ` [PATCH 3/4] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed) Thomas Huth
2021-03-11  8:38   ` Markus Armbruster
2021-03-11  9:14     ` Thomas Huth
2021-03-11 11:37       ` Gerd Hoffmann
2021-03-11 11:45         ` Samuel Thibault
2021-03-11 10:29     ` Paolo Bonzini [this message]
2021-03-10 17:33 ` [PATCH 4/4] usb: Document the missing -usbdevice options Thomas Huth
2021-03-11  8:41 ` [PATCH 0/4] Clean up the -usbdevice mess Gerd Hoffmann
2021-03-11  9:28 ` [PATCH 5/4] usb: Remove "-usbdevice ccid" Thomas Huth
2021-03-17  6:04   ` Thomas Huth
2021-03-17  6:40     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11dbbbed-36c2-c312-7577-c2843b4e368a@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).