From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Beata Michalska" <beata.michalska@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] target/arm: Use extract2 for EXTR
Date: Tue, 9 Jul 2019 20:43:05 +0200 [thread overview]
Message-ID: <11edb5b4-c72f-387d-3a5e-412a546ee902@linaro.org> (raw)
In-Reply-To: <CAFEAcA8k9+XW9uPujk3Zp3CxvYm6Qj6kVEig+KuNO2ywOK0tTA@mail.gmail.com>
On 7/9/19 6:40 PM, Peter Maydell wrote:
> On Tue, 14 May 2019 at 02:11, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> This is, after all, how we implement extract2 in tcg/aarch64.
>>
>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> target/arm/translate-a64.c | 38 ++++++++++++++++++++------------------
>> 1 file changed, 20 insertions(+), 18 deletions(-)
>
> It turns out that we have a regression in booting at least
> some Linux kernels with TCG on aarch64 hosts (the same
> config works fine on x86-64 hosts). Git bisect points to
> this commit (80ac954c369e7e61bd1ed0) as the cause...
Bisect would finger that one, since this second commit is the only method by
which an extract2 operation would be emitted by the aarch64 target + aarch64
host combination.
(The other place that extract2 might be used are deposits, but aarch64 host has
all of those covered with the bfi instruction.)
Fix for tcg/aarch64 coming up...
r~
next prev parent reply other threads:[~2019-07-09 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 1:11 [Qemu-devel] [PATCH 0/2] target/arm: Minor bit field improvements Richard Henderson
2019-05-14 1:11 ` [Qemu-devel] [PATCH 1/2] target/arm: Use extract2 for EXTR Richard Henderson
2019-07-09 16:40 ` Peter Maydell
2019-07-09 18:43 ` Richard Henderson [this message]
2019-05-14 1:11 ` [Qemu-devel] [PATCH 2/2] target/arm: Simplify BFXIL expansion Richard Henderson
2019-05-16 13:16 ` [Qemu-devel] [PATCH 0/2] target/arm: Minor bit field improvements Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11edb5b4-c72f-387d-3a5e-412a546ee902@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=beata.michalska@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).