From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Ruibo Lu <reaperlu@hust.edu.cn>, qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, luruibo2000@163.com,
alistair.francis@wdc.com, liweiwei@iscas.ac.cn
Subject: Re: [PATCH v2] target/riscv: Optimize ambiguous local variable in pmp_hart_has_privs
Date: Mon, 3 Jul 2023 17:54:26 +0200 [thread overview]
Message-ID: <11ff4ac7-75d1-864b-038d-04557926ad26@linaro.org> (raw)
In-Reply-To: <20230703140340.212360-1-reaperlu@hust.edu.cn>
On 3/7/23 16:03, Ruibo Lu wrote:
> These two values represents whether start/end address is in pmp_range.
> However, the type and name of them is ambiguous. This commit change the
> name and type of them to improve code readability and accuracy.
>
> Signed-off-by: Ruibo Lu <reaperlu@hust.edu.cn>
> ---
> target/riscv/pmp.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-07-03 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 14:03 [PATCH v2] target/riscv: Optimize ambiguous local variable in pmp_hart_has_privs Ruibo Lu
2023-07-03 15:54 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11ff4ac7-75d1-864b-038d-04557926ad26@linaro.org \
--to=philmd@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=liweiwei@iscas.ac.cn \
--cc=luruibo2000@163.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=reaperlu@hust.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).