From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A7EDEB64DD for ; Mon, 3 Jul 2023 15:55:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGLso-00088z-3S; Mon, 03 Jul 2023 11:54:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGLsl-00088F-GD for qemu-devel@nongnu.org; Mon, 03 Jul 2023 11:54:32 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGLsk-0003ZI-0V for qemu-devel@nongnu.org; Mon, 03 Jul 2023 11:54:31 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3fbd33a573cso17988285e9.2 for ; Mon, 03 Jul 2023 08:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688399668; x=1690991668; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4QcY9Tnf2ytUomV6p7pqI0Ee7Nx+2k0qmvvW+Mej7nA=; b=BxVCD32WgsSWaCnyGI6751tPxCTih0QWnHAbrx1tJAHLw2fORIxn8bNFXDf/QHBK6v odgzr6I6fvuwbOZWspbaseag+Rr7Jzm3PkXNLNppeHhbruQV/iI1RF+NW1GT5Gp/inWD 1sWZ2tu94Gj57brq1CllXZnnp4tZ4vTuE5voYMjt0JhyL//pCE41WLIhmjL0avJVVB4L EC+XYW7EgCMXlQzKJKo2XinOSwFsGFY0QxhLqwLtbRT1pR4Kna4YINqrJHiz8kT9trNN G41LbfPTniPGZm9vsZZrW7GVw/LiXuRueexKE+qZAdFImFvT62EVrziw3XAYIpGGK/2n DETQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688399668; x=1690991668; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4QcY9Tnf2ytUomV6p7pqI0Ee7Nx+2k0qmvvW+Mej7nA=; b=Lgi9F70kG9ayXHo+lrljYDz1Kv6Wa/ie5Xpvf3s3s08HHMFTOup82RVRa0dCNWEUxQ LVy+3uj1ME11Kz9wN9S/M7qh3klw7s+ll445krc0AzsqLsFcpwe3EIIB/cjYBghi8E6w JGitIPzcS9qDDS32kkFd9yCu8lPbw0z8m3/UrFYvtDdSirF189TE8FtyZAsSIkNXz7Nk VzwMV67cnFeB+wSwE0dw9suQNcJQvhcWm4VsnxSf6AE103g6VVeGjTnRaIZTpsDsOmzB C6ZY33YGFcI+MaTYehs2Mq3A0Qm61cnU5onEBgMIBsmWZDM7WoEfDKvFKPsgYNqtxUEg 2XdA== X-Gm-Message-State: AC+VfDyvMr6Vq0VR68osNkNqCg9eIfkXICNs7GUgHFjauHqNUC1PXgVM TS6TtGrJeZihLiOU3ob2bzrcAw== X-Google-Smtp-Source: ACHHUZ7qJvPeNZeCl6sFIjkDwD9r7pt036WCuNnQz+wBME8w1kRovFpkeUIv3WyCVh6BKFGua3pIPA== X-Received: by 2002:a7b:c409:0:b0:3f8:946:115d with SMTP id k9-20020a7bc409000000b003f80946115dmr8251379wmi.30.1688399668392; Mon, 03 Jul 2023 08:54:28 -0700 (PDT) Received: from [192.168.69.115] ([176.176.178.91]) by smtp.gmail.com with ESMTPSA id a10-20020adfeeca000000b00314103d6daesm13399835wrp.47.2023.07.03.08.54.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jul 2023 08:54:28 -0700 (PDT) Message-ID: <11ff4ac7-75d1-864b-038d-04557926ad26@linaro.org> Date: Mon, 3 Jul 2023 17:54:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2] target/riscv: Optimize ambiguous local variable in pmp_hart_has_privs Content-Language: en-US To: Ruibo Lu , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, luruibo2000@163.com, alistair.francis@wdc.com, liweiwei@iscas.ac.cn References: <20230703140340.212360-1-reaperlu@hust.edu.cn> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230703140340.212360-1-reaperlu@hust.edu.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.09, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/7/23 16:03, Ruibo Lu wrote: > These two values represents whether start/end address is in pmp_range. > However, the type and name of them is ambiguous. This commit change the > name and type of them to improve code readability and accuracy. > > Signed-off-by: Ruibo Lu > --- > target/riscv/pmp.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Philippe Mathieu-Daudé