From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JEvNX-0000DP-HO for qemu-devel@nongnu.org; Tue, 15 Jan 2008 18:39:35 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JEvNW-0000Cs-7d for qemu-devel@nongnu.org; Tue, 15 Jan 2008 18:39:34 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JEvNW-0000Cp-0y for qemu-devel@nongnu.org; Tue, 15 Jan 2008 18:39:34 -0500 Received: from ecfrec.frec.bull.fr ([129.183.4.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JEvNV-0004QN-Nn for qemu-devel@nongnu.org; Tue, 15 Jan 2008 18:39:34 -0500 Subject: Re: [Qemu-devel] Re: [kvm-devel] [RFC][PATCH] Modify loop device to be able to manage partitions of the image disk From: Laurent Vivier In-Reply-To: <20080115182745.GY17783@redhat.com> References: <120042137328-git-send-email-Laurent.Vivier@bull.net> <20080115182745.GY17783@redhat.com> Date: Wed, 16 Jan 2008 00:40:06 +0100 Message-Id: <1200440406.4602.16.camel@frecb07144> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-JVsEJN5Nnqlb55ipPuGy" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: kvm-devel@lists.sourceforge.net --=-JVsEJN5Nnqlb55ipPuGy Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le mardi 15 janvier 2008 =C3=A0 18:27 +0000, Daniel P. Berrange a =C3=A9cri= t : > On Tue, Jan 15, 2008 at 07:22:53PM +0100, Laurent Vivier wrote: > > As it should be useful to be able to mount partition from a=20 > > disk image, (and as I need a break in my bug hunting) I've=20 > > modified the loop driver to mount raw disk image. > >=20 > > To not break original loop device, as we have to change minor=20 > > numbers to manage partitions, a new parameter is added to the module: >=20 > I don't see the point in modifying the loop device driver when you > can already access the partitions with existing device mapper > functionality & tools. There are two reasons: 1- I didn't know kpartx (thank you for the tip) but using loop device, you will be able to use all partition tables known by the kernel (acorn, atari, efi, karma, mac, osf, sun, ultrix, amiga, ibm, ldm, msdos, sgi, sysv68), whereas kpartx can use only partition tables it knows (bsd, dasd, dos, mac, sun, efi, sun, unixware). 2- I'd like to mount qcow2 or others disk image formats, so perhaps it's easier to modify loop device driver (but perhaps you know another magic tool ?) Regards, Laurent --=20 ----------------- Laurent.Vivier@bull.net ------------------ "La perfection est atteinte non quand il ne reste rien =C3=A0 ajouter mais quand il ne reste rien =C3=A0 enlever." Saint Exup=C3=A9ry --=-JVsEJN5Nnqlb55ipPuGy Content-Type: application/pgp-signature; name=signature.asc Content-Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBHjURW9Kffa9pFVzwRAnEsAJ9u+qEuvSwtXr7Y1hpz7iRMKS51hACfe76u WKGs/FIYw+CsXdv7ghEYGHE= =Jb0C -----END PGP SIGNATURE----- --=-JVsEJN5Nnqlb55ipPuGy--