From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: kvm-devel@lists.sourceforge.net, Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH 3/6] Fix daemonize options
Date: Thu, 31 Jan 2008 16:36:17 -0600 [thread overview]
Message-ID: <1201818980-27534-4-git-send-email-aliguori@us.ibm.com> (raw)
In-Reply-To: <1201818980-27534-1-git-send-email-aliguori@us.ibm.com>
The -daemonize option is too restrictive when using with SDL. It also switches
the working directory to / too early which causes block devices with a relative
path to fail.
The -daemonize option is needed for my regression testing so I've included this
patch in the series.
Index: qemu/vl.c
===================================================================
--- qemu.orig/vl.c 2008-01-30 13:47:37.000000000 -0600
+++ qemu/vl.c 2008-01-30 13:47:39.000000000 -0600
@@ -8766,11 +8766,6 @@
}
#ifndef _WIN32
- if (daemonize && !nographic && vnc_display == NULL) {
- fprintf(stderr, "Can only daemonize if using -nographic or -vnc\n");
- daemonize = 0;
- }
-
if (daemonize) {
pid_t pid;
@@ -8808,7 +8803,6 @@
exit(1);
umask(027);
- chdir("/");
signal(SIGTSTP, SIG_IGN);
signal(SIGTTOU, SIG_IGN);
@@ -9067,6 +9061,7 @@
if (len != 1)
exit(1);
+ chdir("/");
TFR(fd = open("/dev/null", O_RDWR));
if (fd == -1)
exit(1);
next prev parent reply other threads:[~2008-01-31 22:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 22:36 [Qemu-devel] [PATCH 0/6] Support for the Kernel Virtual Machine interface Anthony Liguori
2008-01-31 22:36 ` [Qemu-devel] [PATCH 1/6] Use correct types to enable > 2G support Anthony Liguori
2008-01-31 23:54 ` [Qemu-devel] " Paul Brook
2008-02-01 0:25 ` Anthony Liguori
2008-02-01 0:37 ` Paul Brook
2008-02-01 0:40 ` Anthony Liguori
2008-02-01 10:26 ` Fabrice Bellard
2008-02-01 14:35 ` Anthony Liguori
2008-02-01 15:13 ` Avi Kivity
2008-02-01 11:56 ` Robert William Fuller
2008-02-01 16:09 ` M. Warner Losh
2008-02-01 16:47 ` Philip Boulain
2008-02-01 17:35 ` Jamie Lokier
2008-02-01 15:33 ` [Qemu-devel] Re: [kvm-devel] " Anthony Liguori
2008-02-01 15:40 ` Ian Jackson
2008-02-01 17:53 ` [kvm-devel] [Qemu-devel] " Anthony Liguori
2008-02-01 17:57 ` Daniel P. Berrange
2008-02-01 20:31 ` Anthony Liguori
2008-02-01 21:33 ` Paul Brook
2008-02-01 16:00 ` Paul Brook
2008-02-01 16:21 ` Fabrice Bellard
2008-02-05 11:34 ` Ian Jackson
2008-02-01 17:49 ` [Qemu-devel] Re: [kvm-devel] " Anthony Liguori
2008-02-03 8:58 ` Izik Eidus
2008-01-31 22:36 ` [Qemu-devel] [PATCH 2/6] SCI fixes Anthony Liguori
2008-01-31 22:36 ` Anthony Liguori [this message]
2008-01-31 22:36 ` [Qemu-devel] [PATCH 4/6] Tell BIOS about the number of CPUs Anthony Liguori
2008-02-01 0:14 ` [Qemu-devel] " Paul Brook
2008-02-01 0:28 ` Anthony Liguori
2008-02-01 0:40 ` Paul Brook
2008-01-31 22:36 ` [Qemu-devel] [PATCH 5/6] Refactor option ROM loading Anthony Liguori
2008-01-31 22:36 ` [Qemu-devel] [PATCH 6/6] QEMU support for the Kernel Virtual Machine interface Anthony Liguori
2008-02-01 9:49 ` [Qemu-devel] " Fabrice Bellard
2008-02-01 14:18 ` Anthony Liguori
2008-01-31 22:53 ` [qemu-devel] [PATCH 0/6] Support " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201818980-27534-4-git-send-email-aliguori@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).