qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] Fix qemu PPC breakage in monitor.c
@ 2008-02-27 22:35 Jerone Young
  2008-02-28 16:26 ` Jerone Young
  2008-02-28 17:12 ` Anthony Liguori
  0 siblings, 2 replies; 3+ messages in thread
From: Jerone Young @ 2008-02-27 22:35 UTC (permalink / raw)
  To: qemu-devel

# HG changeset patch
# User Jerone Young <jyoung5@us.ibm.com>
# Date 1204150440 21600
# Branch merge
# Node ID f255b23b6ef9461be4ee18fa0745f30c4fb66e6a
# Parent  64a281615f436e65ca7fb2f3c2721c374fbfc8be
Fix qemu PPC breakage in monitor.c

Recent pull of qemu_cvs has added function "qemu_system_cpu_hot_add" to the function "do_cput_set_nr" in monitor.c . Issue is qemu_system_cpu_hot_add is defined in acpi.c which is only compiled for arch with target base i386 (which are i386 & x86-64).

Signed-off-by: Jerone Young <jyoung5@us.ibm.com>

diff --git a/qemu/monitor.c b/qemu/monitor.c
--- a/qemu/monitor.c
+++ b/qemu/monitor.c
@@ -357,7 +357,9 @@ static void do_cpu_set_nr(int value, con
        term_printf("invalid status: %s\n", status);
        return;
     }
+#if defined(TARGET_I386) || defined(TARGET_X86_64)
     qemu_system_cpu_hot_add(value, state);
+#endif
 }
 
 static void do_info_jit(void)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] Fix qemu PPC breakage in monitor.c
  2008-02-27 22:35 [Qemu-devel] [PATCH] Fix qemu PPC breakage in monitor.c Jerone Young
@ 2008-02-28 16:26 ` Jerone Young
  2008-02-28 17:12 ` Anthony Liguori
  1 sibling, 0 replies; 3+ messages in thread
From: Jerone Young @ 2008-02-28 16:26 UTC (permalink / raw)
  To: qemu-devel

For go this patch. It was not in upstream qemu.

On Wed, 2008-02-27 at 16:35 -0600, Jerone Young wrote:
> # HG changeset patch
> # User Jerone Young <jyoung5@us.ibm.com>
> # Date 1204150440 21600
> # Branch merge
> # Node ID f255b23b6ef9461be4ee18fa0745f30c4fb66e6a
> # Parent  64a281615f436e65ca7fb2f3c2721c374fbfc8be
> Fix qemu PPC breakage in monitor.c
> 
> Recent pull of qemu_cvs has added function "qemu_system_cpu_hot_add" to the function "do_cput_set_nr" in monitor.c . Issue is qemu_system_cpu_hot_add is defined in acpi.c which is only compiled for arch with target base i386 (which are i386 & x86-64).
> 
> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
> 
> diff --git a/qemu/monitor.c b/qemu/monitor.c
> --- a/qemu/monitor.c
> +++ b/qemu/monitor.c
> @@ -357,7 +357,9 @@ static void do_cpu_set_nr(int value, con
>         term_printf("invalid status: %s\n", status);
>         return;
>      }
> +#if defined(TARGET_I386) || defined(TARGET_X86_64)
>      qemu_system_cpu_hot_add(value, state);
> +#endif
>  }
> 
>  static void do_info_jit(void)
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] Fix qemu PPC breakage in monitor.c
  2008-02-27 22:35 [Qemu-devel] [PATCH] Fix qemu PPC breakage in monitor.c Jerone Young
  2008-02-28 16:26 ` Jerone Young
@ 2008-02-28 17:12 ` Anthony Liguori
  1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2008-02-28 17:12 UTC (permalink / raw)
  To: qemu-devel, Jerone Young

The CPU hotplug patches have not been applied to QEMU yet.

Regards,,

Anthony Liguori

Jerone Young wrote:
> # HG changeset patch
> # User Jerone Young <jyoung5@us.ibm.com>
> # Date 1204150440 21600
> # Branch merge
> # Node ID f255b23b6ef9461be4ee18fa0745f30c4fb66e6a
> # Parent  64a281615f436e65ca7fb2f3c2721c374fbfc8be
> Fix qemu PPC breakage in monitor.c
>
> Recent pull of qemu_cvs has added function "qemu_system_cpu_hot_add" to the function "do_cput_set_nr" in monitor.c . Issue is qemu_system_cpu_hot_add is defined in acpi.c which is only compiled for arch with target base i386 (which are i386 & x86-64).
>
> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
>
> diff --git a/qemu/monitor.c b/qemu/monitor.c
> --- a/qemu/monitor.c
> +++ b/qemu/monitor.c
> @@ -357,7 +357,9 @@ static void do_cpu_set_nr(int value, con
>         term_printf("invalid status: %s\n", status);
>         return;
>      }
> +#if defined(TARGET_I386) || defined(TARGET_X86_64)
>      qemu_system_cpu_hot_add(value, state);
> +#endif
>  }
>  
>  static void do_info_jit(void)
>
>
>   

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-28 17:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-27 22:35 [Qemu-devel] [PATCH] Fix qemu PPC breakage in monitor.c Jerone Young
2008-02-28 16:26 ` Jerone Young
2008-02-28 17:12 ` Anthony Liguori

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).