From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUlb8-0005Ck-DW for qemu-devel@nongnu.org; Thu, 28 Feb 2008 11:27:06 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUlb3-0005Bd-FD for qemu-devel@nongnu.org; Thu, 28 Feb 2008 11:27:05 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUlb3-0005BZ-CS for qemu-devel@nongnu.org; Thu, 28 Feb 2008 11:27:01 -0500 Received: from e5.ny.us.ibm.com ([32.97.182.145]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JUlb2-0003Yu-UR for qemu-devel@nongnu.org; Thu, 28 Feb 2008 11:27:01 -0500 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e5.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m1SGQj0d008333 for ; Thu, 28 Feb 2008 11:26:45 -0500 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m1SGQioG250372 for ; Thu, 28 Feb 2008 11:26:44 -0500 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m1SGQiD9022040 for ; Thu, 28 Feb 2008 11:26:44 -0500 Received: from [9.53.41.205] (thinkpad.austin.ibm.com [9.53.41.205]) by d01av01.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m1SGQi3n021979 for ; Thu, 28 Feb 2008 11:26:44 -0500 Subject: Re: [Qemu-devel] [PATCH] Fix qemu PPC breakage in monitor.c From: Jerone Young In-Reply-To: References: Content-Type: text/plain Date: Thu, 28 Feb 2008 10:26:44 -0600 Message-Id: <1204216004.6676.8.camel@thinkpad.austin.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: jyoung5@us.ibm.com, qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org For go this patch. It was not in upstream qemu. On Wed, 2008-02-27 at 16:35 -0600, Jerone Young wrote: > # HG changeset patch > # User Jerone Young > # Date 1204150440 21600 > # Branch merge > # Node ID f255b23b6ef9461be4ee18fa0745f30c4fb66e6a > # Parent 64a281615f436e65ca7fb2f3c2721c374fbfc8be > Fix qemu PPC breakage in monitor.c > > Recent pull of qemu_cvs has added function "qemu_system_cpu_hot_add" to the function "do_cput_set_nr" in monitor.c . Issue is qemu_system_cpu_hot_add is defined in acpi.c which is only compiled for arch with target base i386 (which are i386 & x86-64). > > Signed-off-by: Jerone Young > > diff --git a/qemu/monitor.c b/qemu/monitor.c > --- a/qemu/monitor.c > +++ b/qemu/monitor.c > @@ -357,7 +357,9 @@ static void do_cpu_set_nr(int value, con > term_printf("invalid status: %s\n", status); > return; > } > +#if defined(TARGET_I386) || defined(TARGET_X86_64) > qemu_system_cpu_hot_add(value, state); > +#endif > } > > static void do_info_jit(void) > >