From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JdYt5-0002pZ-AW
	for qemu-devel@nongnu.org; Sun, 23 Mar 2008 18:41:59 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JdYt4-0002pN-I1
	for qemu-devel@nongnu.org; Sun, 23 Mar 2008 18:41:58 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JdYt4-0002pK-F8
	for qemu-devel@nongnu.org; Sun, 23 Mar 2008 18:41:58 -0400
Received: from fg-out-1718.google.com ([72.14.220.157])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <dor.laor@gmail.com>) id 1JdYt3-0002qx-U7
	for qemu-devel@nongnu.org; Sun, 23 Mar 2008 18:41:58 -0400
Received: by fg-out-1718.google.com with SMTP id e12so2260073fga.8
	for <qemu-devel@nongnu.org>; Sun, 23 Mar 2008 15:41:57 -0700 (PDT)
Subject: Re: [Qemu-devel] [PATCH] [RFC] Fix time drift of rtc clock +
	general support
In-Reply-To: <200803231619.32472.paul@codesourcery.com>
References: <1206282453.18800.31.camel@localhost.localdomain>
	<200803231619.32472.paul@codesourcery.com>
Content-Type: text/plain
Date: Mon, 24 Mar 2008 00:40:59 +0200
Message-Id: <1206312059.30051.9.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Dor Laor <dor.laor@gmail.com>
Reply-To: dor.laor@qumranet.com, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>, qemu-devel@nongnu.org


On Sun, 2008-03-23 at 16:19 +0000, Paul Brook wrote:
> On Sunday 23 March 2008, Dor Laor wrote:
> > --- a/qemu/hw/irq.c
> > +++ b/qemu/hw/irq.c
> > @@ -30,6 +30,8 @@ struct IRQState {
> >      int n;
> >  };
> >  
> > +uint32_t qemu_irq_acked[NR_IRQ_WORDS];
> 
> This is absolute rubbish. The whole point of the IRQ framework is that it 
> doesn't assume a single flat IRQ controller.
> 

Thanks for the compliments & the review ...
I specifically said that I'll move this variable into per-cpu var.

Moreover, the translation between irq line to vector is handled by the
'qemu_get_irq_vector' that calls 'irq_controller_get_vector' should take
care of the translation.
It works for ioapic, I'm not sure if it works for the flat pic case yet.

Anyway you're welcome to drift without the patch or provide constructive
comments.

> Paul