qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Glauber Costa <gcosta@redhat.com>
To: kvm-devel@lists.sourceforge.net
Cc: glommer@gmail.com, qemu-devel@nongnu.org, macro@linux-mips.org,
	Glauber Costa <gcosta@redhat.com>
Subject: [Qemu-devel] [PATCH] ignore reads to the EOI register.
Date: Wed, 26 Mar 2008 21:57:16 -0300	[thread overview]
Message-ID: <12065794361493-git-send-email-gcosta@redhat.com> (raw)

They seem legal in real hardware, even though the EOI
is a write-only register. By "legal" I mean they are completely
ignored, but at least, don't cause any bits to be set at ESR.

Without this patch, some (very recent) linux git trees will fail
to boot in i386.

This is generated from kvm-userspace, but should apply well to
plain qemu too.

Signed-off-by: Glauber Costa <gcosta@redhat.com>
---
 qemu/hw/apic.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/qemu/hw/apic.c b/qemu/hw/apic.c
index 92248dd..4102493 100644
--- a/qemu/hw/apic.c
+++ b/qemu/hw/apic.c
@@ -615,6 +615,8 @@ static uint32_t apic_mem_readl(void *opaque, target_phys_addr_t addr)
         /* ppr */
         val = apic_get_ppr(s);
         break;
+    case 0x0b:
+        break;
     case 0x0d:
         val = s->log_dest << 24;
         break;
-- 
1.5.0.6

             reply	other threads:[~2008-03-27  1:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27  0:57 Glauber Costa [this message]
2008-03-27  8:18 ` [Qemu-devel] Re: [PATCH] ignore reads to the EOI register Avi Kivity
2008-03-27 11:29   ` Maciej W. Rozycki
     [not found]     ` <87hcesjpqa.fsf@basil.nowhere.org>
2008-03-27 12:55       ` Avi Kivity
2008-03-27 13:36       ` Maciej W. Rozycki
2008-03-27 23:39 ` [Qemu-devel] " Aurelien Jarno
2008-03-28 12:59   ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12065794361493-git-send-email-gcosta@redhat.com \
    --to=gcosta@redhat.com \
    --cc=glommer@gmail.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=macro@linux-mips.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).