qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Andrew Jeffery <andrew@aj.id.au>,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	Joel Stanley <joel@jms.id.au>,
	John Wang <wangzhiqiang.bj@bytedance.com>
Subject: Re: [PATCH] hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a
Date: Tue, 10 Aug 2021 10:49:24 +0200	[thread overview]
Message-ID: <120feac5-4b64-6f84-9ae7-e9a88aa1de98@kaod.org> (raw)
In-Reply-To: <20210810035742.550391-1-linux@roeck-us.net>

Cc: John Wang

On 8/10/21 5:57 AM, Guenter Roeck wrote:
> According to its dts file in the Linux kernel, we need mac0 and mac1 enabled
> instead of mac1 and mac2. Also, g220a is based on aspeed-g5 (ast2500) which
> doesn't even have the third interface.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

> ---
>  hw/arm/aspeed.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index ecf0c9cfac..20e3a77160 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -997,7 +997,7 @@ static void aspeed_machine_g220a_class_init(ObjectClass *oc, void *data)
>      amc->fmc_model = "n25q512a";
>      amc->spi_model = "mx25l25635e";
>      amc->num_cs    = 2;
> -    amc->macs_mask  = ASPEED_MAC1_ON | ASPEED_MAC2_ON;
> +    amc->macs_mask  = ASPEED_MAC0_ON | ASPEED_MAC1_ON;
>      amc->i2c_init  = g220a_bmc_i2c_init;
>      mc->default_ram_size = 1024 * MiB;
>      mc->default_cpus = mc->min_cpus = mc->max_cpus =
> 



      reply	other threads:[~2021-08-10  8:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  3:57 [PATCH] hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a Guenter Roeck
2021-08-10  8:49 ` Cédric Le Goater [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=120feac5-4b64-6f84-9ae7-e9a88aa1de98@kaod.org \
    --to=clg@kaod.org \
    --cc=andrew@aj.id.au \
    --cc=joel@jms.id.au \
    --cc=linux@roeck-us.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wangzhiqiang.bj@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).