[Qemu-devel] [PATCH] Clarify error msg when open of backing file fails

[Beth Kon <eak@us.ibm.com>]

This patch clarifies the error message when a problem is encountered
opening a backing file. Currently the only message printed in this case
is:

" qemu: could not open disk image /path/to/image"

This can be confusing if the real error lies in finding the backing file
rather than the primary file.


diffstat output:
 block.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

Signed-off-by: Beth Kon <eak@us.ibm.com>

---
diff --git a/block.c b/block.c
index bd647a6..c99626f 100644
--- a/block.c
+++ b/block.c
@@ -416,8 +416,11 @@ int bdrv_open2(BlockDriverState *bs, const char
*filename, 
         }
         path_combine(backing_filename, sizeof(backing_filename),
                      filename, bs->backing_file);
-        if (bdrv_open(bs->backing_hd, backing_filename, 0) < 0)
-            goto fail;
+        if (bdrv_open(bs->backing_hd, backing_filename, 0) < 0) {
+            fprintf(stderr, "qemu: could not open backing file %s\n",
+                                             backing_filename);
+            goto fail; 
+        }    
     }
 
     /* call the change callback */


-- 
Elizabeth Kon (Beth)
IBM Linux Technology Center
Open Hypervisor Team
email: eak@us.ibm.com